Skip to content

fix: remove redundant minimum payable amount from Sell Appliance modal #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zhey-on wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove redundant minimum payable amount from Sell Appliance modal #1373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions src/frontend/src/modules/Client/Appliances/SellApplianceModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,25 +286,6 @@
</span>
</md-field>
</div>
<div class="md-layout-item md-size-100 md-small-size-100">
<md-field>
<label for="minimumPayableAmount">
{{
applianceService.appliance.rateType === "weekly"
? $tc("phrases.minimumPayableAmount", 1)
: $tc("phrases.minimumPayableAmount", 2)
}}
</label>
<md-input
type="number"
id="minimumPayableAmount"
name="minimumPayableAmount"
v-model="minimumPayableAmount"
readonly
disabled
/>
</md-field>
</div>
</form>
</md-tab>
</md-tabs>
Expand Down Expand Up @@ -528,7 +509,6 @@ export default {
selectedApplianceId: null,
deviceSelectionList: [],
isDeviceSelectionRequired: false,
minimumPayableAmount: 0,
selectedDeviceSerial: null,
showRates: false,
loading: false,
Expand Down Expand Up @@ -822,8 +802,7 @@ export default {
) {
this.applianceService.appliance.rate = 0
}
this.minimumPayableAmount = 0
this.rateCost = 0
this.applianceService.appliance.rateCost = 0
},
calculateRateCountsOnRateCostChange() {
const remainingCost =
Expand All @@ -835,18 +814,15 @@ export default {
"warn",
"Rate cost can not be bigger than remaining cost",
)
this.minimumPayableAmount = 0
this.applianceService.appliance.rate = 0
return
}
if (installmentCost < 1 || typeof installmentCost !== "number") {
this.minimumPayableAmount = 0
this.applianceService.appliance.rate = 0
return
}
this.minimumPayableAmount = Math.floor(installmentCost)
this.applianceService.appliance.rate = Math.floor(
remainingCost / this.minimumPayableAmount,
remainingCost / installmentCost,
)
},
isDeviceBindingRequired(appliance) {
Expand Down