Bump wasm-bindgen #314
Merged
Bump wasm-bindgen #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To be clear, this doesn't include the fix for the stack space leak in wasm-bindgen (they haven't pushed a release for this yet). Instead, it's meant to fix wasm-bindgen/wasm-bindgen#2605 |
Contributor
|
@SebastienGllmt @vsubhuman do we want to try and get this into 10.0.0 too or does it need any more testing or anything? |
Contributor
Author
|
We use this branch in multiple places and no issue so far. The diff in the generated WASM code is just a single line (basically only fixes this specific issue)
|
vsubhuman
approved these changes
Feb 1, 2022
Member
vsubhuman
left a comment
vsubhuman
left a comment
There was a problem hiding this comment.
Thank you, @SebastienGllmt !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.2.75 of wasm-bindgen fixes a bug when using nodejs + webpack v5 but we're still on 0.2.74 so I bump the version