RandomImprove : panicked at 'cannot sample empty range' #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irst loop and added a test-case for it
Member
Author
|
@rooooooooob , check plz when possible |
pedromtcosta
approved these changes
Nov 8, 2021
rooooooooob
approved these changes
Nov 8, 2021
Contributor
rooooooooob
left a comment
rooooooooob
left a comment
There was a problem hiding this comment.
LGTM, that was an oversight on my part since the other test didn't catch it.
Member
Author
Yeah, I've also completely missed it on the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue when random-improve uses all available inputs in the first loop and added a test-case for it
Before that it was failing with: