Added PrivateKey::from_bech32() #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method existed already in js-chain-libs where we got this class from to begin wtih. It also exists in the other 3 keys types: PublicKey, Bip32PublicKey and Bip32PrivateKey so it makes sense to add here.
Contributor
Author
Contributor
Author
|
It should fix #237 directly |
This was
linked to
issues
Nov 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method existed already in js-chain-libs where we got this class
from to begin wtih. It also exists in the other 3 keys types:
PublicKey, Bip32PublicKey and Bip32PrivateKey so it makes sense to add here.
taken from here
I'm not sure why it wasn't there to begin with. I didn't see it being removed in the git histories either yet it was in js-chain-libs.