Update to nightly-2022-10-15 #954
Conversation
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
LGTM, the only addressable comment would be the one about not passing None (it might not matter now but we wouldn't want weird bugs in the future if we start relying on it).
EDIT: oops, you pushed the change in tests, which will definitely break at least 4 of them (try running cargo test -p rustc_codegen_spirv --lib to see what I mean).
| } | ||
| bx.set_span(span); | ||
| bx.call(entry_func.ty, entry_func, &call_args, None); | ||
| bx.call(entry_func.ty, None, entry_func, &call_args, None); |
There was a problem hiding this comment.
You can pass Some if you change this function (shader_entry_stub) to take the whole FnAbi (and call it entry_fn_abi) instead of arg_abis (which is the .args field of that very FnAbi).
There was a problem hiding this comment.
What happened here? I see thumbs up but also marked as resolved and no change?
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
This looks ready but I'm not sure if you want to pass Some(entry_fn_abi) from that entry.rs function or not.
| } | ||
| bx.set_span(span); | ||
| bx.call(entry_func.ty, entry_func, &call_args, None); | ||
| bx.call(entry_func.ty, None, entry_func, &call_args, None); |
There was a problem hiding this comment.
What happened here? I see thumbs up but also marked as resolved and no change?
Opened a PR to move us off of |
|
Apparently forgot to use the param in the actual call 😬 |
2 participants
The new
fn_abiparameter inBuilderMethods::call()andinvoke()scares me a bit. Here's the relevant PR in rust-langTests pass and examples run.
With 2022-10-29 we're up to date for the new Rust 1.66 stable that's going to be released on Dec 15.
EDIT Back to 10-15 because of a blocked issue (
diagnostic_outputbeing removed fromConfig)