Skip to content

Print diagnostic for missing clarification files#249

Merged
mergify[bot] merged 2 commits into
EmbarkStudios:mainfrom
khodzha:license_file
Oct 13, 2020
Merged

Print diagnostic for missing clarification files#249
mergify[bot] merged 2 commits into
EmbarkStudios:mainfrom
khodzha:license_file

Conversation

@khodzha

@khodzha khodzha commented Aug 18, 2020

Copy link
Copy Markdown
Contributor

Resolves: #190

@khodzha

khodzha commented Aug 18, 2020

Copy link
Copy Markdown
Contributor Author

this should address #190
it looks like this running in this repo
image

@khodzha khodzha force-pushed the license_file branch 2 times, most recently from 11c48c9 to 8aa388c Compare August 18, 2020 20:29
@Jake-Shadle Jake-Shadle changed the title print notification when a file from license-files list doesnt exist Print diagnostic for missing clarification files Oct 13, 2020
@Jake-Shadle Jake-Shadle self-requested a review October 13, 2020 11:42

@Jake-Shadle Jake-Shadle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR, I'm really sorry how long it took me to get around to merging it!

@mergify mergify Bot merged commit 4e068f7 into EmbarkStudios:main Oct 13, 2020
@khodzha khodzha deleted the license_file branch October 13, 2020 11:46
@khodzha

khodzha commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

its ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarification with incorrect path doesn't error

2 participants