Install active toolchain by default if rust-version is not passed - #92
Merged
Merged
Conversation
Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
AhmedSoliman
added a commit
to restatedev/restate
that referenced
this pull request
Mar 3, 2025
Rustup 1.28 has been released and it disables toolchain auto installation. See [rust-lang/rustup#3985], cargo-deny-action has released a fix on v2 at EmbarkStudios/cargo-deny-action#92
AhmedSoliman
added a commit
to restatedev/restate
that referenced
this pull request
Mar 3, 2025
Rustup 1.28 has been released and it disables toolchain auto installation. See [rust-lang/rustup#3985], cargo-deny-action has released a fix on v2 at EmbarkStudios/cargo-deny-action#92
chris-olszewski
added a commit
to vercel/turborepo
that referenced
this pull request
Mar 3, 2025
### Description See EmbarkStudios/cargo-deny-action#92 ### Testing Instructions CI job passes
This was referenced Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Starting with v1.28, rustup is not going to install active toolchain by default and that might break some uses, like:
Not sure if this is the best solution, but this PR tries to preserve the previous behaviour of rustup as described in https://blog.rust-lang.org/2025/03/02/Rustup-1.28.0.html#whats-new-in-rustup-1280
Related Issues