-
Notifications
You must be signed in to change notification settings - Fork 43
Update and remove clearly defined #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| #[serde(deny_unknown_fields)] | ||
| pub struct GitInfo { | ||
| pub sha1: String, | ||
| pub dirty: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change led to reports like
[WARN] failed to validate all files specified in clarification for crate const-str 0.6.2: unable to retrieve 'LICENSE' for crate 'const-str 0.6.2' from remote git host: failed to deserialize '/Users/jrose/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/const-str-0.6.2/.cargo_vcs_info.json': missing field
dirtyat line 4 column 3
when attempting to update to cargo-about 0.8.0. Perhaps it should be marked #[serde(default)]? I didn't check the precise conditions when crates.io will omit it, though.
|
Unfortunately v0.8.1 didn't help with Kl4rry/simp#46, I still get |
|
Thanks for the new release. |
|
You need to add |
Thanks! I cannot do this, @Kl4rry needs to allow this. |
Updates crates, applies a few PRs, and removes support for clearly defined.
Closes: #282
Closes: #283