Skip to content

Conversation

@Jake-Shadle
Copy link
Member

@Jake-Shadle Jake-Shadle commented Sep 4, 2025

Updates crates, applies a few PRs, and removes support for clearly defined.

Closes: #282
Closes: #283

@Jake-Shadle Jake-Shadle merged commit 484005c into main Sep 4, 2025
13 checks passed
@Jake-Shadle Jake-Shadle deleted the update branch September 4, 2025 16:21
#[serde(deny_unknown_fields)]
pub struct GitInfo {
pub sha1: String,
pub dirty: bool,
Copy link

@jrose-signal jrose-signal Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change led to reports like

[WARN] failed to validate all files specified in clarification for crate const-str 0.6.2: unable to retrieve 'LICENSE' for crate 'const-str 0.6.2' from remote git host: failed to deserialize '/Users/jrose/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/const-str-0.6.2/.cargo_vcs_info.json': missing field dirty at line 4 column 3

when attempting to update to cargo-about 0.8.0. Perhaps it should be marked #[serde(default)]? I didn't check the precise conditions when crates.io will omit it, though.

@0323pin
Copy link

0323pin commented Sep 19, 2025

Unfortunately v0.8.1 didn't help with Kl4rry/simp#46, I still get

error: failed to run custom build command for `simp v3.10.1 (/usr/pkgsrc/graphics/simp/work/simp-3.10.1)`

Caused by:
  process didn't exit successfully: `/usr/pkgsrc/graphics/simp/work/simp-3.10.1/target/release/build/simp-51e7ce57dd28cbd0/build-script-build` (exit status: 101)
  --- stdout
  cargo:rustc-env=GIT_HASH=
  cargo:rerun-if-changed=Cargo.toml

  --- stderr
  2025-09-19 5:47:38.818519756 +00:00:00 [ERROR] TOML parse error at line 1, column 12
    |
  1 | accepted = [
    |            ^
  'LGPL-2.1' is not a valid SPDX licensee: LGPL-2.1
  ^^^^^^^^ a deprecated license identifier was used


  thread 'main' panicked at build.rs:58:9:

@0323pin
Copy link

0323pin commented Sep 19, 2025

Thanks for the new release.
v0.8.2 gives me a different error.

error: failed to run custom build command for `simp v3.10.1 (/usr/pkgsrc/graphics/simp/work/simp-3.10.1)`

Caused by:
  process didn't exit successfully: `/usr/pkgsrc/graphics/simp/work/simp-3.10.1/target/release/build/simp-51e7ce57dd28cbd0/build-script-build` (exit status: 101)
  --- stdout
  cargo:rustc-env=GIT_HASH=
  cargo:rerun-if-changed=Cargo.toml

  --- stderr
  2025-09-19 19:18:24.390656252 +00:00:00 [WARN] LicenseRef-UFL-1.0 has no license file for crate 'epaint_default_fonts 0.29.1'
  error: failed to satisfy license requirements
     ┌─ /usr/pkgsrc/graphics/simp/work/vendor/imagepipe-0.5.0/Cargo.toml:20:12
     │
  20 │ license = "LGPL-3.0-only"
     │            -------------

  error: failed to satisfy license requirements
     ┌─ /usr/pkgsrc/graphics/simp/work/vendor/multicache-0.6.1/Cargo.toml:20:12
     │
  20 │ license = "LGPL-3.0-only"
     │            -------------

  2025-09-19 19:18:24.405310356 +00:00:00 [ERROR] encountered 2 errors resolving licenses, unable to generate output

@Jake-Shadle
Copy link
Member Author

You need to add LGPL-3.0-only to your accept list.

@0323pin
Copy link

0323pin commented Sep 20, 2025

You need to add LGPL-3.0-only to your accept list.

Thanks! I cannot do this, @Kl4rry needs to allow this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants