-
Notifications
You must be signed in to change notification settings - Fork 961
docs: Split Mac install instructions #8648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| export LDFLAGS="-L/opt/homebrew/opt/sqlite/lib" | ||
| export CPPFLAGS="-I/opt/homebrew/opt/sqlite/include" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a version of this in our makefile for Apple Darwin already, so it may just work already? But builds work on my machine...so I'm scared to also take this out of the instruction set for macOS incase this somehow breaks the build for other people lol 👀
Perhaps we should be bold and take it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Makefile feels like a better place to put this for sure 🤔
|
|
||
| ```shell | ||
| brew install sqlite | ||
| export LDFLAGS="-L/usr/local/opt/sqlite/lib" | ||
| export CPPFLAGS="-I/usr/local/opt/sqlite/include" | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, they will also need the openssl library. These lines can go away once #8647 gets merged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @ddustin! Thanks so much for this!
3de9a7c to
4b0d918
Compare
Okay, so I think this is what happened to me: 1) I had brew installed on my Intel Mac 2) I got an Apple Silicon Mac 3) I setup my new Mac by copying over Intel Mac harddrive 4) I now have two brew's installed on my machine: a) /usr/local/bin/brew (for intel macs & cross-compiling) b) /opt/homebrew/bin/brew (for (for apple silicon) 5) The wrong brew was in my path (a) Looking through our getting started docs, we seem to reference both /usr/local/... and opt/homebrew/... Update the installation document to mac this and related issues more clear for new users who might run into this problem. Changelog-None
4b0d918 to
73c1e9f
Compare
Okay, so I think this is what happened to me:
a) /usr/local/bin/brew (for intel macs & cross-compiling)
b) /opt/homebrew/bin/brew (for (for apple silicon)
Looking through our getting started docs, we seem to reference both /usr/local/... and opt/homebrew/...
Update the installation document to mac this and related issues more clear for new users who might run into this problem.
Changelog-None