Skip to content

db: replace UPDATE FROM syntax for SQLite compat #8246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustyrussell merged 1 commit into from
Apr 23, 2025
Merged

db: replace UPDATE FROM syntax for SQLite compat #8246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions wallet/db.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2043,11 +2043,10 @@ static void migrate_convert_old_channel_keyidx(struct lightningd *ld,

stmt = db_prepare_v2(db, SQL("UPDATE addresses"
" SET addrtype = ?"
" FROM channels "
" WHERE addresses.keyidx = channels.shutdown_keyidx_local"
" AND channels.state != ?"
" AND channels.state != ?"
" AND channels.state != ?"));
" WHERE keyidx IN (SELECT shutdown_keyidx_local FROM channels"
" WHERE state != ?"
" AND state != ?"
" AND state != ?)"));
db_bind_int(stmt, wallet_addrtype_in_db(ADDR_ALL));
/* If we might have already seen onchain funds, we need to rescan */
db_bind_int(stmt, channel_state_in_db(FUNDING_SPEND_SEEN));
Expand Down
Loading