fix(radio): do not show Onebit on unsupported handsets#6611
Merged
Conversation
rotorman
changed the title
pfeerick
reviewed
Sep 30, 2025
pfeerick
reviewed
Sep 30, 2025
pfeerick
reviewed
Sep 30, 2025
pfeerick
changed the title
pfeerick
changed the title
Co-authored-by: Peter Feerick <pfeerick@users.noreply.github.com>
Co-authored-by: Peter Feerick <pfeerick@users.noreply.github.com>
Co-authored-by: Peter Feerick <pfeerick@users.noreply.github.com>
Collaborator
Author
|
I recheck the availablility of onbit on h7, and while I couldn't find a mention to it in application notes, it does still exist at LL api level. Yet I think it should be removed anyway. It's only reason to exist in EdgeTX was trying to get some some kbps from older radio where speed was hardware limited by slow inverters. So overall, I still think we should get rid of it |
Member
|
Yes, indeed... if any "modern" designs needed it, they would probably warrant an ELRS style "avoid like the plague" announcement. 🤭 😇 |
pfeerick
pushed a commit
that referenced
this pull request
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onebit doesn't exist for H7 class MCU