Skip to content

feat: add Joshua Bardwell's voice package#148

Merged
pfeerick merged 6 commits intoEdgeTX:mainfrom
ricardocarva:feature/Joshua-Bardwell-OpenTX-EdgeTX-Voicepack
Jun 13, 2025
Merged

feat: add Joshua Bardwell's voice package#148
pfeerick merged 6 commits intoEdgeTX:mainfrom
ricardocarva:feature/Joshua-Bardwell-OpenTX-EdgeTX-Voicepack

Conversation

@ricardocarva
Copy link
Contributor

Summary

This pull request implements the request from TheBlueGreen/Joshua-Bardwell-OpenTX-EdgeTX-Voicepack#8:

"[Request]: PR to EdgeTX for auto inclusion in EdgeTX Buddy etc"

Background

The original issue was opened by a Joshua Bardwell member requesting automatic inclusion of the voicepack in EdgeTX Buddy.
See the original discussion and request (including any images or context) at the above link.

What this PR does

  • Adds voicepack with several recordings by Joshua Bardwell that was made available here.
  • Updated sounds.json to include a brief description as recommended in the screenshot from the original discussion

Additional context

This PR is submitted on behalf of the original requester as discussed in the linked issue.
If any further details are needed, please refer to the original issue.

Thank you for your consideration 🚀

@ricardocarva
Copy link
Contributor Author

@pfeerick is this failing the checks because some file names are too long?
I couldn't tell for sure based on the log.

@pfeerick
Copy link
Member

pfeerick commented Jun 9, 2025

The errors are pretty clear:

image

Filename of a system file (i.e. located in the SYSTEM directory) is max 8 character plus extension.
Filename of a non-system (i.e. located in next folder up from SYSTEM) is max 6 characters plus extension.

This has been the case since OpenTX 2.2 (or earlier), and was the case until EdgeTX 2.11 (non-system filename was increased to 8 characters plus extension - so consistent for both system and non-system files) so will need to update this build check.

@pfeerick
Copy link
Member

pfeerick commented Jun 9, 2025

Right, now just down to the filenames that are still too long (all over 8 characters in length).

image

The build checks currently don't check the file extension, so you can either change the extension to something else, and I make it so the build checks only verify the .wav file extension lengths, or figure out some other way to allow the checks to validate. i.e. maybe a prefix or suffix to the filename?

@ricardocarva
Copy link
Contributor Author

@pfeerick I reduced the name of those file names that were showing up in the log, so they're no longer over 8 characters in length

@pfeerick pfeerick changed the title Include Joshua Bardwell's voice package in the Sounds directory. feat: add Joshua Bardwell's voice package Jun 13, 2025
@pfeerick
Copy link
Member

Thanks for that... let's roll with it! :)

@pfeerick pfeerick merged commit ab300b7 into EdgeTX:main Jun 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants