Skip to content

Add Korean (ko-KR) voice pack and update documentation#143

Merged
pfeerick merged 2 commits intoEdgeTX:mainfrom
siyeongjang:add-korean-voicepack
Apr 21, 2025
Merged

Add Korean (ko-KR) voice pack and update documentation#143
pfeerick merged 2 commits intoEdgeTX:mainfrom
siyeongjang:add-korean-voicepack

Conversation

@siyeongjang
Copy link
Contributor

Summary

This PR adds a complete Korean (ko-KR) voice pack to the EdgeTX SD card sounds.

Details

  • Voice files generated using Google Cloud Text-to-Speech (Wavenet-B)
  • Audio format: 16-bit PCM, Mono, 32kHz
  • Files located in: SOUNDS/ko
  • Index files:
    • voices/ko-KR.csv — system phrases
    • voices/ko-KR_scripts.csv — script-specific terms
  • Korean section added to README.md with contributor and generation details

Contributor

Created and contributed by @siyeongjang
to improve accessibility for Korean-speaking RC users.

Feedback and suggestions are welcome.

@pfeerick
Copy link
Member

pfeerick commented Apr 19, 2025

Thank you for the contribution! Looks like you have one field too many in ko-KR.csv... the content of "Korean" should be in the "Translation" column. And ko-KR_scripts.csv has missing fields. Run build-checks.py to validate locally. If it doesn't affect your workflow, can you also add double quotes to the fields for consistency. I'm still hoping at some point in the future we can use crowdln or similar for translation, and (and more remote future hope) potentially merge all the languages into one file.

…pts.csv

- Standardized field structure based on voice.csv
- Added missing translation entries
- Removed unnecessary files
- Added missing .wav files under SOUNDS/ko/
@siyeongjang
Copy link
Contributor Author

Updated ko-KR.csv and ko-KR_scripts.csv:

  • Aligned field structure with voice.csv
  • Added 20+ missing entries and formatted all fields with double quotes
  • Added missing .wav files under SOUNDS/ko/
  • Removed unnecessary .Zone.Identifier files and added ignore rule

All checks now pass locally. Please review when available. Thanks again!

@pfeerick
Copy link
Member

Looks good to me... thank you! :)

@pfeerick pfeerick merged commit be011db into EdgeTX:main Apr 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants