Skip to content

feat: make GLaDOS "Welcome to EdgeTX" sound better#135

Merged
pfeerick merged 1 commit intoEdgeTX:mainfrom
davenewt:hello
Mar 9, 2025
Merged

feat: make GLaDOS "Welcome to EdgeTX" sound better#135
pfeerick merged 1 commit intoEdgeTX:mainfrom
davenewt:hello

Conversation

@davenewt
Copy link
Contributor

@davenewt davenewt commented Mar 6, 2025

Small edit to remove the gap between "t" and "x" of "welcome to edgetx" to make this sound a little better. This is my first PR so I hope it works! Thank you for the great work!

@pfeerick
Copy link
Member

pfeerick commented Mar 9, 2025

The only problem with editing the files directly/manually is the changes could be lost in a future run of the generation script, as these are all automatically generated. It is somewhat unlikely given this is the hello.wav. Ideally though you would do post-processing as part of voice-gen-glados.py if any tweaks are necessary.

@pfeerick pfeerick changed the title Edit en_gb-glados hello feat: make GLaDOS "Welcome to EdgeTX" sound better Mar 9, 2025
@pfeerick pfeerick merged commit a7ace0e into EdgeTX:main Mar 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants