Skip to content

Conversation

@ekluzek
Copy link
Contributor

@ekluzek ekluzek commented Jan 18, 2025

Fix the relative path option for input_pathname in namelist definition files. This now allows using a "rel:" prefix for it.
The usage is to use that prefix in front of a namelist variable name that will be used as the relative path for the pathname of the file.

So for example (if rundir is added to the namelist definiton file to be from the XML variable RUNDIR), you can do something like:

<input_pathname>rel:rundir</input_pathname>

Which will then prepend the filename for that variable with the RUNDIR directory, and also add it to the relevant .input_data_list file so that filename will be checked for existence.

Test suite: So far only tested a single case with a CMEPS PR that includes a namelist item with a rel: option for input_pathname
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #4738
User interface changes?: No

Update gh-pages html (Y/N)?: No

I do plan on doing more testing, so I'll report more on what I do later. But I will also note that this is pretty isolated, so unlikely to cause problems. And it's only loosening a XSD check so can't cause problems with existing things that work. I would like to add some type of test that would catch this type of problem, but I haven't figured out how to do that yet. So I'd love to hear suggestions on that.

@ekluzek ekluzek added Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM ty: Bug Fix tp: config labels Jan 18, 2025
@ekluzek ekluzek changed the title Fix so that the "rel:<namelist_var>" option can be used for input_pathname in namelist definition files [WIP]: Fix so that the "rel:<namelist_var>" option can be used for input_pathname in namelist definition files Jan 18, 2025
@ekluzek ekluzek added the Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group label Jan 18, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.67%. Comparing base (a89f680) to head (fe5bf83).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4739      +/-   ##
==========================================
- Coverage   31.43%   28.67%   -2.76%     
==========================================
  Files         264      263       -1     
  Lines       38683    38630      -53     
  Branches     8386     8376      -10     
==========================================
- Hits        12161    11079    -1082     
- Misses      25281    26479    +1198     
+ Partials     1241     1072     -169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group tp: config ty: Bug Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relative path option for input_pathname in namelist definition doesn't work because the namelist XSD doesn't allow colons

1 participant