This repository was archived by the owner on Jun 12, 2020. It is now read-only.
Feature channel subscribe #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
|
Xstoudi
suggested changes
Jun 12, 2018
Member
Xstoudi
left a comment
Xstoudi
left a comment
There was a problem hiding this comment.
Ptit résumé :
- Les messages du bot sont en français
- Mettre le chemin de la DB dans les variables d'environnement
- Ne pas spammer le channel dès que quelqu'un s'abonne/se désabonne. Si tu dois avoir un message d'erreur ou un message de confirmation, préfère les messages privés.
- Supprimer le message qui contient la commande (pour toutes les commandes)
config/prod.json
Outdated
| "JSKongress" | ||
| ] | ||
| ], | ||
| "subscriber": { |
Member
There was a problem hiding this comment.
Cette config devrait être en variable d'environnement.
index.js
Outdated
| @@ -1,16 +1,24 @@ | |||
| require('dotenv').config() | |||
Member
There was a problem hiding this comment.
Pas nécessaire pour la prod, tu peux virer ça et ajouter les variables d'environnement dans ta commande.
src/commands/subscriber.js
Outdated
| channel: message.channel.name | ||
| }) | ||
| if (subscribedChannel !== null) { | ||
| return message.channel.send(`${message.author.username} already have subscribed to the channel \`#${message.channel.name}\``) |
Member
There was a problem hiding this comment.
J'imagine que ce n'est pas la peine d'avertir la planète entière que le mec s'est abonné.
src/commands/subscriber.js
Outdated
| userId: message.author.id, | ||
| channel: message.channel.name | ||
| }) | ||
| return message.channel.send(`${message.author.username} has subscribed to the channel \`#${message.channel.name}\``) |
Member
There was a problem hiding this comment.
J'imagine que ce n'est pas la peine d'avertir la planète entière que le mec s'est abonné.
src/commands/subscriber.js
Outdated
| userId: message.author.id | ||
| }) | ||
| if (subscribedChannels.length === 0) return message.channel.send('You haven\'t subscribed to a channel') | ||
| return message.channel.send(`${message.author.username} has subscribed to this channels :\n${subscribedChannels.map(a => `\`#${a.channel}\``).join('\n')}`) |
Member
There was a problem hiding this comment.
J'imagine que ce n'est pas la peine d'avertir la planète entière que le mec s'est abonné.
src/commands/subscriber.js
Outdated
| const subscribedChannels = subs.find({ | ||
| userId: message.author.id | ||
| }) | ||
| if (subscribedChannels.length === 0) return message.channel.send('You haven\'t subscribed to a channel') |
Member
There was a problem hiding this comment.
J'imagine que ce n'est pas la peine d'avertir la planète entière que le mec ne s'est pas abonné.
src/commands/subscriber.js
Outdated
| }) | ||
| if (subscribedChannel !== null) { | ||
| subs.remove(subscribedChannel) | ||
| return message.channel.send(`${message.author.username} has unsubscribed to the channel \`#${message.channel.name}\``) |
src/commands/subscriber.js
Outdated
| subs.remove(subscribedChannel) | ||
| return message.channel.send(`${message.author.username} has unsubscribed to the channel \`#${message.channel.name}\``) | ||
| } | ||
| return message.channel.send(`${message.author.username} hasn't subscribed to the channel \`#${message.channel.name}\``) |
src/commands/subscriber.js
Outdated
| channel: message.channel.name | ||
| }) | ||
| if (subscribersOnChannel.length === 0) { | ||
| return message.channel.send(`There is no subscribers for this channel.`) |
src/commands/subscriber.js
Outdated
| if (subscribersOnChannel.length === 0) { | ||
| return message.channel.send(`There is no subscribers for this channel.`) | ||
| } | ||
| return message.channel.send(`${args.join(' ')} |
Member
There was a problem hiding this comment.
Supprimer le message qui contient la commande avant de faire ça.
Member
Author
|
Done |
Xstoudi
approved these changes
Jun 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout des commandes:
!subscribe [list]: s'abonne à un channel / affiche la list des channel auxquels on est abonnés!unsubscribe: se désabonne a un channel!alert <message>: envoi une alerte a toutes les personnes aboonée a ce channel