Added logging and failure return when Highs::presolve() is called and…#3016
Merged
Conversation
… incumbent model is a QP
Member
Author
|
Maybe my |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3016 +/- ##
==========================================
- Coverage 72.77% 72.77% -0.01%
==========================================
Files 417 417
Lines 102059 102070 +11
Branches 16450 16451 +1
==========================================
+ Hits 74278 74279 +1
- Misses 27505 27515 +10
Partials 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
filikat
approved these changes
May 11, 2026
filikat
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
Maybe my
clang-formatis out of date?
The formatting looks correct to me. I think some files in the hipo-in-python PR were not formatted correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted - thanks to @gghisa that if a QP has been passed to HiGHS, and then
Highs::presolve()is called, the corresponding LP is presolved.This prints a logging line and returns
HighsStatus::kError. Tested intest-qjh