Skip to content

Added logging and failure return when Highs::presolve() is called and…#3016

Merged
jajhall merged 1 commit into
latestfrom
no-qp-presolve
May 11, 2026
Merged

Added logging and failure return when Highs::presolve() is called and…#3016
jajhall merged 1 commit into
latestfrom
no-qp-presolve

Conversation

@jajhall

@jajhall jajhall commented May 11, 2026

Copy link
Copy Markdown
Member

Spotted - thanks to @gghisa that if a QP has been passed to HiGHS, and then Highs::presolve() is called, the corresponding LP is presolved.

This prints a logging line and returns HighsStatus::kError. Tested in test-qjh

@jajhall jajhall requested a review from filikat May 11, 2026 16:20
@jajhall

jajhall commented May 11, 2026

Copy link
Copy Markdown
Member Author

Maybe my clang-format is out of date?

@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.77%. Comparing base (652149e) to head (072c93b).
⚠️ Report is 204 commits behind head on latest.

Files with missing lines Patch % Lines
highs/HighsExternalDeps.h 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3016      +/-   ##
==========================================
- Coverage   72.77%   72.77%   -0.01%     
==========================================
  Files         417      417              
  Lines      102059   102070      +11     
  Branches    16450    16451       +1     
==========================================
+ Hits        74278    74279       +1     
- Misses      27505    27515      +10     
  Partials      276      276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@filikat filikat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Maybe my clang-format is out of date?

The formatting looks correct to me. I think some files in the hipo-in-python PR were not formatted correctly.

@jajhall jajhall merged commit 60626f8 into latest May 11, 2026
496 of 498 checks passed
@jajhall jajhall deleted the no-qp-presolve branch May 11, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants