Install readme and license files to the right location#3001
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3001 +/- ##
=======================================
Coverage 72.80% 72.81%
=======================================
Files 417 417
Lines 102156 102149 -7
Branches 16467 16464 -3
=======================================
+ Hits 74374 74378 +4
+ Misses 27506 27495 -11
Partials 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks: we merge into latest, not master |
Member
|
@galabovaa Please would you resolve the merge conflict and review the PR |
https://packaging.python.org/en/latest/specifications/core-metadata/#classifier-multiple-use Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://packaging.python.org/en/latest/specifications/core-metadata/#license-file-multiple-use Fixes ERGO-Code#2999. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Contributor
|
LGTM, what do you think @mathgeekcoder ? Shall we do the same for highspy-extras afterwards? (can be in another PR) |
galabovaa
approved these changes
May 14, 2026
Collaborator
Looks good! Agreed @galabovaa, definitely need to do similar for |
mathgeekcoder
approved these changes
May 14, 2026
Contributor
|
Thank you, @andersk! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LICENSE.txt,README.md,THIRD_PARTY_NOTICES.md#2999.With this fix, the sdist
highspy-1.14.0.tar.gzstill containsand the wheel
highspy-1.14.0-cp314-cp314-linux_x86_64.whlcontainswhere
METADATAlistsLicense-Expression: MIT,License-File: LICENSE.txt,License-File: THIRD_PARTY_NOTICES.md, and includes the contents ofREADME.md.Documentation:
pyproject.tomllicense,license-filesLicense-Expression,License-File,Classifier(deprecated forLicense ::in favor ofLicense-Expression)