Critical UI Fixes for Manage Accounts Page#48
Merged
jcardenas9x merged 3 commits intodevelopfrom May 14, 2019
Merged
Conversation
…e public key of an account made the entire account hidden in the manage accounts page. Repurposed 'edit' account to 'view' account due to mismatched UX.
jcardenas9x
added
bug
mjk90
approved these changes
May 14, 2019
Contributor
mjk90
left a comment
mjk90
left a comment
There was a problem hiding this comment.
All looks good. Working correctly when tested 👍 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
updateauthaction to change a permission's public key completely hides the account in the Manage Accounts page. Now, the account will be visible in the "Import Account" panel but only the key(s) that got changed will have blank private key fields. If only one public key got changed, the other key is still usable.