Skip to content

Fogbugz 3381 - Fixed create account validation#44

Merged
mjk90 merged 4 commits intodevelopfrom
create-account-validation
May 10, 2019
Merged

Fogbugz 3381 - Fixed create account validation#44
mjk90 merged 4 commits intodevelopfrom
create-account-validation

Conversation

@mjk90
Copy link
Copy Markdown
Contributor

@mjk90 mjk90 commented May 10, 2019

Updated create account validation regex to catch account names which start with a number

Copy link
Copy Markdown
Contributor

@varshajnagaraja varshajnagaraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also update the information below Account name text box to inform the user that the name also should not start with number

@mjk90
Copy link
Copy Markdown
Contributor Author

mjk90 commented May 10, 2019

I think you should also update the information below Account name text box to inform the user that the name also should not start with number

Account Name description has now been updated

Comment thread src/pages/PermissionPage/components/CreateAccount/CreateAccount.jsx Outdated
Comment thread src/pages/PermissionPage/components/CreateAccount/CreateAccount.jsx Outdated
@mjk90
Copy link
Copy Markdown
Contributor Author

mjk90 commented May 10, 2019

@jcardenas9x @varshajnagaraja I've removed the "starts with number" validation and also removed some other redundant validation

@mjk90 mjk90 merged commit 0c01e56 into develop May 10, 2019
@mjk90 mjk90 deleted the create-account-validation branch May 10, 2019 08:08
@mjk90 mjk90 restored the create-account-validation branch May 14, 2019 09:02
@jcardenas9x jcardenas9x deleted the create-account-validation branch May 15, 2019 09:14
@jcardenas9x jcardenas9x added the bug Something isn't working label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants