Skip to content

Adjustments to in-app console log terminal#110

Merged
jcardenas9x merged 2 commits intodevelopfrom
console-logger-fix
May 29, 2019
Merged

Adjustments to in-app console log terminal#110
jcardenas9x merged 2 commits intodevelopfrom
console-logger-fix

Conversation

@jcardenas9x
Copy link
Contributor

Changes

  • Added a new behavior to the in-app console log: The badge containing the number of unseen messages will be reset when navigating to another page, since these messages are tied to the developer tool console. The developer tool console clears every time you navigate to a new page, but the badge does not get reset.
  • Added a check to the helper function that dispatches the log open action: To ensure the console log does not randomly appear even if there are no visible events in the developer console, the function now checks if an error object and/or message have been passed to the function. If nothing has been passed to this helper function, the helper function does nothing.

…avigating to a different page from the current view
… to another page. Added a check to only dispatch console log reveal action if there is an actual error object/message
@jcardenas9x jcardenas9x added bug Something isn't working enhancement New feature or request labels May 29, 2019
@jcardenas9x jcardenas9x merged commit c07095c into develop May 29, 2019
@jcardenas9x jcardenas9x deleted the console-logger-fix branch May 29, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants