Skip to content

implement post-prepare hook for GCCcore to also have a wrapper in place with system type prefix like 'x86_64-pc-linux-gnu' #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trz42 merged 2 commits into from
May 30, 2023
Merged

implement post-prepare hook for GCCcore to also have a wrapper in place with system type prefix like 'x86_64-pc-linux-gnu' #251

trz42 merged 2 commits into from
May 30, 2023

Conversation

@boegel
Copy link
Contributor

@boegel boegel commented May 27, 2023 •
edited
Loading

fixes #250

(draft, being tested)

@boegel
implement post-prepare hook for GCCcore to also have a wrapper in pla…
7554604 
…ce with system type prefix like 'x86_64-pc-linux-gnu'
@eessi-bot
Copy link

eessi-bot bot commented May 27, 2023

Instance eessi-bot-citc-aws is configured to build:

  • arch x86_64/generic for repo EESSI-pilot
  • arch x86_64/intel/haswell for repo EESSI-pilot
  • arch x86_64/intel/skylake_avx512 for repo EESSI-pilot
  • arch x86_64/amd/zen2 for repo EESSI-pilot
  • arch x86_64/amd/zen3 for repo EESSI-pilot
  • arch aarch64/generic for repo EESSI-pilot
  • arch aarch64/graviton2 for repo EESSI-pilot
  • arch aarch64/graviton3 for repo EESSI-pilot

@trz42 trz42 mentioned this pull request May 27, 2023
Closed
@boegel boegel mentioned this pull request May 27, 2023
Closed
@boegel
patch copied wrapper script to make sure it's actually working (CMD n…
c2ec231 
…eeds to be set to 'ld' for 'x86_64-pc-linux-gnu-ld', because EasyBuild's rpath_args.py only takes into account 'ld' when determining whether or not to use -Wl,-rpath or just -rpath
@boegel boegel marked this pull request as ready for review May 27, 2023 18:29
@boegel
Copy link
Contributor Author

boegel commented May 27, 2023

I've tested this hook for installing GCCcore/11.3.0 on top of EESSI 2023.04 compat layer, works like a charm (in combination with easybuilders/easybuild-easyblocks#2921).

@boegel boegel requested a review from trz42 May 27, 2023 22:29
trz42
trz42 approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested by building GCC/11.3.0 and GCC/12.2.0.

@trz42 trz42 merged commit b0998c5 into EESSI:main May 30, 2023
@boegel boegel deleted the GCCcore_hook_extra_linker_wrappers branch May 30, 2023 06:52
trz42 pushed a commit to trz42/software-layer that referenced this pull request Jan 23, 2024
@poksumdo
Merge pull request EESSI#251 from trz42/adjust_archdetect_specs_and_c…
20df2f7 
…i_to_nessi

cleanup archdetect: specs for archs provided by NESSI and CI tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trz42 trz42 trz42 approved these changes

Assignees

No one assigned

Labels

pilot-2023.04

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

failing installation of GCCcore/10.3.0 on top of EESSI 2023.04 compat layer

2 participants

@boegel @trz42