接頭辞 arr のプロパティは array 宣言とし、配列で初期化する

[seasoftjapan]

初期化済みだっけ? という一手間を省けると期待する。

例

-public $arrParam;
+public array $arrParam = [];

想定している対象箇所

$ git grep -E '^(\s*)((public|protected|private|static)\s+)+(\$arr[^=]*?)(;)'
data/class/SC_CheckError.php:    public $arrParam;
data/class/SC_CustomerList.php:    public $arrColumnCSV;
data/class/SC_Date.php:    public static $arrHoliday;
data/class/SC_Date.php:    public static $arrRegularHoliday;
data/class/SC_Fpdf.php:    public $arrPref;
data/class/SC_Fpdf.php:    public $arrMessage;
data/class/SC_Fpdf.php:    public $arrData;
data/class/SC_Fpdf.php:    public $arrDisp;
data/class/SC_Product.php:    public $arrClassName;
data/class/SC_Product.php:    public $arrClassCatName;
data/class/SC_Product.php:    public $arrOrderData;
data/class/SC_SelectSql.php:    public $arrSql;
data/class/SC_SelectSql.php:    public $arrVal;
data/class/SC_SendMail.php:    public $arrRecip;
data/class/graph/SC_Graph_Base.php:    public $arrRGB;
data/class/graph/SC_Graph_Base.php:    public $arrColor;
data/class/graph/SC_Graph_Base.php:    public $arrDarkColor;
data/class/graph/SC_Graph_Base.php:    public $arrLegend;
data/class/graph/SC_Graph_Line.php:    public $arrXLabel;
data/class/graph/SC_Graph_Line.php:    public $arrDataList;   // グラフデータを格納
data/class/graph/SC_Graph_Line.php:    public $arrPointList;  // 折れ線座標を格納
data/class/graph/SC_Graph_Pie.php:    public $arrLabel;
data/class/graph/SC_Graph_Pie.php:    public $arrData;
data/class/helper/SC_Helper_CSV.php:    public $arrSubnavi;
data/class/helper/SC_Helper_CSV.php:    public $arrSubnaviName;
data/class/helper/SC_Helper_Mail.php:    public $arrMAILTPLPATH;
data/class/helper/SC_Helper_Mail.php:    protected $arrPref;
data/class/helper/SC_Helper_Mail.php:    protected $arrCountry;
data/class/helper/SC_Helper_Transform.php:    protected $arrSmartyTagsOrg;
data/class/helper/SC_Helper_Transform.php:    protected $arrSmartyTagsSub;
data/class/helper/SC_Helper_Transform.php:    protected $arrErr;
data/class/helper/SC_Helper_Transform.php:    protected $arrElementTree;
data/class/helper/SC_Helper_Transform.php:    protected $arrSelectElements;
data/class/pages/LC_Page.php:    public $arrSiteInfo;
data/class/pages/LC_Page.php:    public $arrInfo;
data/class/pages/LC_Page.php:    public $arrForm;
data/class/pages/LC_Page.php:    public $arrErr;
data/class/pages/LC_Page.php:    public $arrPageLayout;
data/class/pages/LC_Page.php:    public $arrClassCat1;
data/class/pages/LC_Page.php:    public $arrPref;
data/class/pages/LC_Page.php:    public $arrProductType;
data/class/pages/LC_Page.php:    public $arrData;
data/class/pages/LC_Page.php:    public $arrJob;
data/class/pages/LC_Page.php:    public $arrReminder;
data/class/pages/LC_Page.php:    public $arrCountry;
data/class/pages/LC_Page.php:    public $arrSex;
data/class/pages/LC_Page.php:    public $arrMAILMAGATYPE;
data/class/pages/LC_Page.php:    public $arrMagazineType;
data/class/pages/LC_Page.php:    public $arrMailMagazineType;
data/class/pages/LC_Page.php:    public $arrMailTEMPLATE;
data/class/pages/LC_Page.php:    public $arrMAILTEMPLATE;
data/class/pages/LC_Page.php:    public $arrYear;
data/class/pages/LC_Page.php:    public $arrMonth;
data/class/pages/LC_Page.php:    public $arrDay;
data/class/pages/LC_Page.php:    public $arrMinutes;
data/class/pages/LC_Page.php:    public $arrStatus;
data/class/pages/LC_Page.php:    public $arrSTATUS;
data/class/pages/LC_Page.php:    public $arrSTATUS_IMAGE;
data/class/pages/LC_Page.php:    public $arrDELIVERYDATE;
data/class/pages/LC_Page.php:    public $arrPRODUCTLISTMAX;
data/class/pages/LC_Page.php:    public $arrTAXCALCRULE;
data/class/pages/LC_Page.php:    public $arrDeliv;
data/class/pages/LC_Page.php:    public $arrPrices;
data/class/pages/LC_Page.php:    public $arrDelivDate;
data/class/pages/LC_Page.php:    public $arrDelivTime;
data/class/pages/LC_Page.php:    public $arrPayment;
data/class/pages/LC_Page.php:    public $arrPayments;
data/class/pages/LC_Page.php:    public $arrPageMax;
data/class/pages/LC_Page.php:    public $arrPagenavi;
data/class/pages/LC_Page.php:    public $arrSubnavi;
data/class/pages/LC_Page.php:    public $arrProducts;
data/class/pages/LC_Page.php:    public $arrShipping;
data/class/pages/LC_Page.php:    public $arrHidden;
data/class/pages/LC_Page.php:    public $arrParam;
data/class/pages/LC_Page.php:    public $arrNews;
data/class/pages/LC_Page.php:    public $arrCatList;
data/class/pages/LC_Page.php:    public $arrSearchData;
data/class/pages/LC_Page.php:    public $arrMaker;
data/class/pages/LC_Page.php:    public $arrRecommend;
data/class/pages/LC_Page.php:    public $arrProductsList;
data/class/pages/LC_Page.php:    public $arrRECOMMEND;
data/class/pages/LC_Page.php:    public $arrReview;
data/class/pages/LC_Page.php:    public $arrWDAY;
data/class/pages/LC_Page.php:    public $arrOrder;
data/class/pages/LC_Page.php:    public $arrCustomer;
data/class/pages/LC_Page_Sitemap.php:    public $arrPageList;
data/class/pages/admin/LC_Page_Admin.php:    public $arrTAXRULE;
data/class/pages/admin/LC_Page_Admin.php:    public $arrDeviceType;
data/class/pages/admin/LC_Page_Admin.php:    public $arrBlocs;
data/class/pages/admin/LC_Page_Admin.php:    public $arrPageData;
data/class/pages/admin/LC_Page_Admin.php:    public $arrEditPage;
data/class/pages/admin/LC_Page_Admin.php:    public $arrRegistYear;
data/class/pages/admin/LC_Page_Admin.php:    public $arrBirthYear;
data/class/pages/admin/LC_Page_Admin.php:    public $arrTemplate;
data/class/pages/admin/LC_Page_Admin.php:    public $arrORDERSTATUS;
data/class/pages/admin/LC_Page_Admin.php:    public $arrORDERSTATUS_COLOR;
data/class/pages/admin/LC_Page_Admin.php:    public $arrResults;
data/class/pages/admin/LC_Page_Admin.php:    public $arrAllShipping;
data/class/pages/admin/LC_Page_Admin.php:    public $arrSearchHidden;
data/class/pages/admin/LC_Page_Admin.php:    public $arrPRODUCTSTATUS_COLOR;
data/class/pages/admin/LC_Page_Admin.php:    public $arrDISP;
data/class/pages/admin/LC_Page_Admin.php:    public $arrAUTHORITY;
data/class/pages/admin/LC_Page_Admin.php:    public $arrWORK;
data/class/pages/admin/LC_Page_Admin.php:    public $arrStartYear;
data/class/pages/admin/LC_Page_Admin.php:    public $arrStartMonth;
data/class/pages/admin/LC_Page_Admin.php:    public $arrStartDay;
data/class/pages/admin/LC_Page_Admin.php:    public $arrEndYear;
data/class/pages/admin/LC_Page_Admin.php:    public $arrEndMonth;
data/class/pages/admin/LC_Page_Admin.php:    public $arrEndDay;
data/class/pages/admin/LC_Page_Admin.php:    public $arrCatKey;
data/class/pages/admin/LC_Page_Admin.php:    public $arrCatVal;
data/class/pages/admin/LC_Page_Admin.php:    public $arrList;
data/class/pages/admin/LC_Page_Admin.php:    public $arrTree;
data/class/pages/admin/LC_Page_Admin.php:    public $arrParentID;
data/class/pages/admin/LC_Page_Admin.php:    public $arrClass;
data/class/pages/admin/LC_Page_Admin.php:    public $arrClassCatCount;
data/class/pages/admin/LC_Page_Admin.php:    public $arrClassCat;
data/class/pages/admin/LC_Page_Admin.php:    public $arrAllowedTag;
data/class/pages/admin/LC_Page_Admin.php:    public $arrTitle;
data/class/pages/admin/LC_Page_Admin_Home.php:    public $arrSoldout;
data/class/pages/admin/LC_Page_Admin_Home.php:    public $arrNewOrder;
data/class/pages/admin/basis/LC_Page_Admin_Basis.php:    public $arrRegularHoliday;
data/class/pages/admin/basis/LC_Page_Admin_Basis_Delivery.php:    public $arrDelivList;
data/class/pages/admin/basis/LC_Page_Admin_Basis_Holiday.php:    public $arrHoliday;
data/class/pages/admin/basis/LC_Page_Admin_Basis_Kiyaku.php:    public $arrKiyaku;
data/class/pages/admin/basis/LC_Page_Admin_Basis_Payment.php:    public $arrPaymentListFree;
data/class/pages/admin/basis/LC_Page_Admin_Basis_PaymentInput.php:    public $arrFile;
data/class/pages/admin/basis/LC_Page_Admin_Basis_Tax.php:    public $arrErr;
data/class/pages/admin/basis/LC_Page_Admin_Basis_Tax.php:    public $arrEnable;
data/class/pages/admin/basis/LC_Page_Admin_Basis_Tax.php:    public $arrTaxrule;
data/class/pages/admin/contents/LC_Page_Admin_Contents_CSV.php:    public $arrSubnaviName;
data/class/pages/admin/contents/LC_Page_Admin_Contents_CSV.php:    public $arrSelected;
data/class/pages/admin/contents/LC_Page_Admin_Contents_CSV.php:    public $arrOptions;
data/class/pages/admin/contents/LC_Page_Admin_Contents_CsvSql.php:    public $arrColList;
data/class/pages/admin/contents/LC_Page_Admin_Contents_CsvSql.php:    public $arrSqlList;
data/class/pages/admin/contents/LC_Page_Admin_Contents_CsvSql.php:    public $arrTableList;
data/class/pages/admin/contents/LC_Page_Admin_Contents_FileManager.php:    public $arrFileList;
data/class/pages/admin/contents/LC_Page_Admin_Contents_Recommend.php:    public $arrItems;
data/class/pages/admin/contents/LC_Page_Admin_Contents_Recommend.php:    public $arrCatList;
data/class/pages/admin/customer/LC_Page_Admin_Customer_Edit.php:    public $arrSearchErr;
data/class/pages/admin/customer/LC_Page_Admin_Customer_Edit.php:    public $arrPurchaseHistory;
data/class/pages/admin/customer/LC_Page_Admin_Customer_SearchCustomer.php:    public $arrCustomer;
data/class/pages/admin/design/LC_Page_Admin_Design.php:    public $arrTarget;
data/class/pages/admin/design/LC_Page_Admin_Design_Bloc.php:    public $arrBlocList;
data/class/pages/admin/design/LC_Page_Admin_Design_CSS.php:    public $arrCSSList;
data/class/pages/admin/design/LC_Page_Admin_Design_MainEdit.php:    public $arrPageList;
data/class/pages/admin/mail/LC_Page_Admin_Mail.php:    public $arrPageRows;
data/class/pages/admin/mail/LC_Page_Admin_Mail.php:    public $arrHtmlmail;
data/class/pages/admin/mail/LC_Page_Admin_Mail.php:    public $arrMailType;
data/class/pages/admin/mail/LC_Page_Admin_Mail_History.php:    public $arrDataList;
data/class/pages/admin/mail/LC_Page_Admin_Mail_Template.php:    public $arrTemplates;
data/class/pages/admin/order/LC_Page_Admin_Order_Edit.php:    public $arrYearShippingDate;
data/class/pages/admin/order/LC_Page_Admin_Order_Edit.php:    public $arrMonthShippingDate;
data/class/pages/admin/order/LC_Page_Admin_Order_Edit.php:    public $arrDayShippingDate;
data/class/pages/admin/order/LC_Page_Admin_Order_Edit.php:    public $arrBirthMonth;
data/class/pages/admin/order/LC_Page_Admin_Order_Edit.php:    public $arrBirthDay;
data/class/pages/admin/order/LC_Page_Admin_Order_Mail.php:    public $arrMailHistory;
data/class/pages/admin/order/LC_Page_Admin_Order_Pdf.php:    public $arrType;
data/class/pages/admin/order/LC_Page_Admin_Order_Pdf.php:    public $arrDownload;
data/class/pages/admin/ownersstore/LC_Page_Admin_OwnersStore_Log.php:    public $arrLogDetail;
data/class/pages/admin/ownersstore/LC_Page_Admin_OwnersStore_Log.php:    public $arrInstallLogs;
data/class/pages/admin/ownersstore/LC_Page_Admin_OwnersStore_PluginHookPointList.php:    public $arrUse;
data/class/pages/admin/ownersstore/LC_Page_Admin_OwnersStore_PluginHookPointList.php:    public $arrConflict;
data/class/pages/admin/ownersstore/LC_Page_Admin_OwnersStore_PluginHookPointList.php:    public $arrHookPoint;
data/class/pages/admin/ownersstore/LC_Page_Admin_OwnersStore_Settings.php:    public $arrForm;
data/class/pages/admin/ownersstore/LC_Page_Admin_OwnersStore_Settings.php:    public $arrErr;
data/class/pages/admin/products/LC_Page_Admin_Products_Product.php:    public $arrCatOut;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSV.php:    public $arrTagCheckItem;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSV.php:    public $arrProductColumn;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSV.php:    public $arrProductClassColumn;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSV.php:    public $arrFormKeyList;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSV.php:    public $arrRowErr;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSV.php:    public $arrRowResult;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSVCategory.php:    public $arrErr;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSVCategory.php:    public $arrTitle;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSVCategory.php:    public $arrRowResult;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSVCategory.php:    public $arrRowErr;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSVCategory.php:    public $arrTagCheckItem;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSVCategory.php:    public $arrRegistColumn;
data/class/pages/admin/products/LC_Page_Admin_Products_UploadCSVCategory.php:    public $arrFormKeyList;
data/class/pages/admin/system/LC_Page_Admin_System_Bkup.php:    public $arrBkupList;
data/class/pages/admin/system/LC_Page_Admin_System_Masterdata.php:    public $arrMasterDataName;
data/class/pages/admin/system/LC_Page_Admin_System_Masterdata.php:    public $arrMasterData;
data/class/pages/admin/system/LC_Page_Admin_System_Parameter.php:    public $arrKeys;
data/class/pages/admin/system/LC_Page_Admin_System_Parameter.php:    public $arrComments;
data/class/pages/admin/system/LC_Page_Admin_System_Parameter.php:    public $arrValues;
data/class/pages/admin/system/LC_Page_Admin_System_System.php:    public $arrSystemInfo;
data/class/pages/admin/total/LC_Page_Admin_Total.php:    public $arrSearchForm1;
data/class/pages/admin/total/LC_Page_Admin_Total.php:    public $arrSearchForm2;
data/class/pages/cart/LC_Page_Cart.php:    public $arrData;
data/class/pages/frontparts/bloc/LC_Page_FrontParts_Bloc.php:    public $arrCartList;
data/class/pages/frontparts/bloc/LC_Page_FrontParts_Bloc_Calendar.php:    public $arrCalendar;
data/class/pages/frontparts/bloc/LC_Page_FrontParts_Bloc_Category.php:    public $arrParentID;
data/class/pages/frontparts/bloc/LC_Page_FrontParts_Bloc_Category.php:    public $arrCat;
data/class/pages/frontparts/bloc/LC_Page_FrontParts_Bloc_Category.php:    public $arrTree;
data/class/pages/frontparts/bloc/LC_Page_FrontParts_Bloc_Recommend.php:    public $arrBestProducts;
data/class/pages/frontparts/bloc/LC_Page_FrontParts_Bloc_SearchProducts.php:    public $arrMakerList;
data/class/pages/mypage/LC_Page_AbstractMypage.php:    public $arrCustomerOrderStatus;
data/class/pages/mypage/LC_Page_Mypage_Delivery.php:    public $arrOtherDeliv;
data/class/pages/mypage/LC_Page_Mypage_Favorite.php:    public $arrFavorite;
data/class/pages/products/LC_Page_Products_CategoryList.php:    public $arrCategory;
data/class/pages/products/LC_Page_Products_CategoryList.php:    public $arrChildren;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrClassCat2;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrSTATUS;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrSTATUS_IMAGE;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrDELIVERYDATE;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrRECOMMEND;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrProduct;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrClassCat1;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrForm;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrRelativeCat;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrReview;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrRecommend;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrFile;
data/class/pages/products/LC_Page_Products_Detail.php:    public $arrErr;
data/class/pages/products/LC_Page_Products_Review.php:    public $arrRECOMMEND;
data/class/pages/products/LC_Page_Products_Review.php:    public $arrSex;
data/class/pages/products/LC_Page_Products_Review.php:    public $arrReviewDenyURL;
data/class/pages/rss/LC_Page_Rss_Products.php:    public $arrProduct;
data/class/pages/shopping/LC_Page_Shopping_Confirm.php:    public $arrCartItems;
data/class/pages/shopping/LC_Page_Shopping_Deliv.php:    public $arrAddr;
data/class/plugin/SC_Plugin_Base.php:    protected $arrSelfInfo;
data/class/plugin/SC_Plugin_Installer.php:    protected $arrPlugin;
data/class/plugin/SC_Plugin_Installer.php:    protected $arrInstallData;
tests/class/SC_CheckError/SC_CheckError_AbstractTestCase.php:    protected $arrForm;
tests/class/SC_CheckError/SC_CheckError_HTML_TAG_CHECKTest.php:    protected $arrAllowedTag;
tests/class/SC_CustomerTest.php:    protected $arrCustomer;
tests/class/helper/SC_Helper_Mail/SC_Helper_Mail_TestBase.php:    protected $arrCustomer;
tests/class/helper/SC_Helper_Purchase/SC_Helper_Purchase_cancelOrderTest.php:    private $arrProductsClasses;
tests/class/util/SC_Utils/SC_Utils_sfArrKeyValueTest.php:    public $arrList;

[seasoftjapan]

把握している範囲だと、以下でイレギュラーな対応が必要そう。

• ec-cube2/data/class/SC_Product.php

  Line 87 in 93b9886

  if (is_array($this->arrOrderData) && $objQuery->order == '') {

  • (空配列でなく)初期化されていない事を想定した実装となっている。➔ is_array() -> !empty() に変更する。

• ec-cube2/data/class/pages/shopping/LC_Page_Shopping_Payment.php

  Line 136 in 93b9886

  $this->arrDelivDate = $objPurchase->getDelivDate($objCartSess, $cart_key);

  • false を受け取りうる。➔ false の代わりに空配列を使う。(テンプレートは空配列でも動作する。) 多分、getDateArray() の else 句を削れば良い。
  • 後方互換として array|false とするか検討の余地がある。
  • LC_Page で定義しているが、LC_Page_Shopping_Payment で定義するのが妥当そう。