Skip to content

Conversation

@mjgrzybek
Copy link
Contributor

@mjgrzybek mjgrzybek commented Jul 15, 2022

Description

Cherry-picked 67ff210 and e64f1ca dependabot PRs.

Switch from configmap to configmapleases as lock object for leaderselection - as described: kubernetes-sigs/controller-runtime#1773.

10:55:01.401660       1 leaderelection.go:248] attempting to acquire leader lease dynatrace/dynatrace-operator-lock...
10:55:01.405545       1 leaderelection.go:258] successfully acquired lease dynatrace/dynatrace-operator-lock          

How can this be tested?

  • CI
  • run operator
  • scale operator deployment to >1 and verify if leaderselection works correctly

Checklist

- [ ] Unit tests have been updated/added

@mjgrzybek mjgrzybek added the core Changes to core functionality of the Operator label Jul 15, 2022
@mjgrzybek mjgrzybek requested a review from a team as a code owner July 15, 2022 11:21
@mjgrzybek mjgrzybek force-pushed the feature/bump-k8s-io-modules branch 2 times, most recently from 803f39b to de0498f Compare July 15, 2022 11:25
gkrenn
gkrenn previously approved these changes Jul 20, 2022
@mjgrzybek mjgrzybek enabled auto-merge (squash) July 20, 2022 09:21
dependabot bot and others added 3 commits July 20, 2022 11:23
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.23.1 to 0.24.2.
- [Release notes](https://github.com/kubernetes/api/releases)
- [Commits](kubernetes/api@v0.23.1...v0.24.2)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) from 0.23.1 to 0.24.2.
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.23.1...v0.24.2)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@mjgrzybek mjgrzybek merged commit 1cdd18c into master Jul 20, 2022
@mjgrzybek mjgrzybek deleted the feature/bump-k8s-io-modules branch July 20, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes to core functionality of the Operator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants