Skip to content

DYN-10279 Add workflow - validate-skills#16961

Merged
QilongTang merged 12 commits into
DynamoDS:masterfrom
avidit:kca/dyn-10279
Mar 16, 2026
Merged

DYN-10279 Add workflow - validate-skills#16961
QilongTang merged 12 commits into
DynamoDS:masterfrom
avidit:kca/dyn-10279

Conversation

@avidit

@avidit avidit commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Purpose

Declarations

Check these if you believe they are true

Release Notes

N/A

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copilot AI review requested due to automatic review settings March 12, 2026 21:39

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10279

Comment thread .github/workflows/validate_agent_skills.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions workflow to validate changes under .agents/skills/ using an external skill-validator tool, with a companion bash script to determine which skill folders changed and emit markdown results into the job summary.

Changes:

  • Introduces a new PR-scoped workflow that runs when files under .agents/skills/** change.
  • Adds a bash script to compute changed skill directories (via git diff) and run skill-validator per skill.
  • Emits validator output to both GitHub Actions annotations and the job summary.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/validate-skills.yml New workflow to run Go-based skill-validator on PRs touching .agents/skills/**.
.github/scripts/validate-skill.sh New script to detect changed skill directories and run validation with markdown summary output.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread .github/workflows/validate-skills.yml Outdated
Comment thread .github/scripts/validate_skills.sh
Comment thread .github/scripts/validate-skill.sh
Comment thread .github/workflows/validate_agent_skills.yml Outdated
@QilongTang

QilongTang commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

oh wow, @avidit were we working on similar stuff? #16962 should we merge the check into one?

@avidit

avidit commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

oh wow, @avidit were we working on similar stuff? #16962 should we merge the check into one?

Sounds good.

Comment thread .github/agents/dynamo-dotnet-expert.agent.md Outdated
Comment thread .github/agents/dynamo-jira-ticket.agent.md Outdated
Comment thread .github/workflows/validate_agent_skills.yml
Comment thread .github/workflows/disabled/cherry-picking.yaml
Comment thread .github/agents/dynamo-skill-writer.agent.md Outdated
@avidit avidit requested a review from QilongTang March 13, 2026 20:28
Comment thread .github/workflows/validate_agent_skills.yml Fixed
@@ -74,13 +74,13 @@ Load the relevant reference when working on that content type.

| Content Type | When to Use | Reference |
|-------------|-------------|-----------|
| **UI content** | Error messages, notifications, labels, tooltips | [UI content guidelines](references/ui-content.md) |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe references is the folder following agent skill standard

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the pattern of dynamo codebase patterns agent here. We might have to create a skill for this as well and create agent wrapper.

@QilongTang QilongTang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment then LGTM

@sonarqubecloud

Copy link
Copy Markdown

@QilongTang QilongTang merged commit d5c09e2 into DynamoDS:master Mar 16, 2026
30 of 31 checks passed
@avidit avidit deleted the kca/dyn-10279 branch March 16, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants