Skip to content

DYN-8469: Disallow empty groups with pins#15915

Merged
zeusongit merged 1 commit into
DynamoDS:masterfrom
zeusongit:pin-grp
Mar 10, 2025
Merged

DYN-8469: Disallow empty groups with pins#15915
zeusongit merged 1 commit into
DynamoDS:masterfrom
zeusongit:pin-grp

Conversation

@zeusongit

Copy link
Copy Markdown
Contributor

Purpose

While deleting nodes from groups, if the only remaining items in the group are a node and a pin, when removing the node should remove the group as well.

DynamoSandbox_unyV3IMPBb

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

While deleting nodes from groups, if the only remaining items in the group are a node and a pin, when removing the node should remove the group as well.

Reviewers

@DynamoDS/dynamo

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8469

@zeusongit zeusongit added this to the 3.5 milestone Mar 9, 2025
@avidit

avidit commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

@zeusongit Safe to ignore smoke test failure here. Looks like some issues with the build agent.

@zeusongit zeusongit merged commit b19e0b0 into DynamoDS:master Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants