Add icon for Solid.ByRuledLoft#11165
Conversation
aparajit-pratap
left a comment
There was a problem hiding this comment.
@mmisol I think you also need to check in the icon png files.
|
@aparajit-pratap They are embedded into the resx file |
|
We do check them in here: https://github.com/DynamoDS/Dynamo/tree/master/src/Resources/ProtoGeometry. Also the node description does not match: https://git.autodesk.com/Dynamo/LibG/blob/dc73830fad6f0ef274af0c306cbc0592aa234088/LibG.Interface/IGeometryFactory.cs#L879 |
|
@mmisol I think I know why the node description has not been updated. The code comments in IGeometryFactory.cs need to also be copied to ProtoGeometry. We have to do this manually for now as the T4 template auto-generation is broken currently. Hoewever, we can make that change later. If you could just add the png's, we can merge this PR. |
Purpose
Adds icons created by Jingyi for the new node Solid.ByRuledLoft.
Here is a screenshot of how they look like in Dynamo:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @aparajit-pratap