Skip to content

Add API Verification tests#259

Merged
damianh merged 1 commit intomainfrom
dh/intro-apiverification-tests
Sep 20, 2025
Merged

Add API Verification tests#259
damianh merged 1 commit intomainfrom
dh/intro-apiverification-tests

Conversation

@damianh
Copy link
Member

@damianh damianh commented Sep 20, 2025

No description provided.

@damianh damianh added this to the intro-7.0,0 milestone Sep 20, 2025
@damianh damianh self-assigned this Sep 20, 2025
Copilot AI review requested due to automatic review settings September 20, 2025 10:45
@damianh damianh added impact/non-breaking The fix or change will not be a breaking one area/foss/introspection labels Sep 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces public API verification tests for the OAuth2Introspection authentication package and modernizes JSON serialization by replacing the custom SimpleJson library with the standard System.Text.Json API.

  • Adds API verification testing using PublicApiGenerator to track public API changes
  • Replaces SimpleJson with System.Text.Json throughout test utilities
  • Removes the entire custom SimpleJson implementation (over 2100 lines)

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
PublicApiVerification.cs New test class for verifying public API surface using PublicApiGenerator
PublicApiVerification.VerifyPublicApi.verified.txt Baseline file containing the verified public API surface (1449 lines)
PipelineFactory.cs Updated to use JsonSerializer.Serialize instead of SimpleJson
IntrospectionEndpointHandler.cs Updated to use JsonSerializer.Serialize instead of SimpleJson
SimpleJson.cs Removed entire custom JSON library implementation
AssemblyInfo.cs Added console capture configuration for tests
*.csproj Added PublicApiGenerator and Verify.XunitV3 package references

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@damianh damianh force-pushed the dh/intro-apiverification-tests branch from 2194102 to 4542983 Compare September 20, 2025 10:48
@damianh damianh requested a review from Copilot September 20, 2025 10:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@damianh damianh force-pushed the dh/intro-apiverification-tests branch from 4542983 to f136dd2 Compare September 20, 2025 10:54
@damianh damianh force-pushed the dh/intro-apiverification-tests branch from f136dd2 to b646f31 Compare September 20, 2025 10:58
@damianh damianh enabled auto-merge September 20, 2025 11:06
@damianh damianh requested review from bhazen and Copilot September 20, 2025 11:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@damianh damianh merged commit 659837b into main Sep 20, 2025
3 checks passed
@damianh damianh deleted the dh/intro-apiverification-tests branch September 20, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/foss/introspection impact/non-breaking The fix or change will not be a breaking one

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants