Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces public API verification tests for the OAuth2Introspection authentication package and modernizes JSON serialization by replacing the custom SimpleJson library with the standard System.Text.Json API.
- Adds API verification testing using PublicApiGenerator to track public API changes
- Replaces SimpleJson with System.Text.Json throughout test utilities
- Removes the entire custom SimpleJson implementation (over 2100 lines)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| PublicApiVerification.cs | New test class for verifying public API surface using PublicApiGenerator |
| PublicApiVerification.VerifyPublicApi.verified.txt | Baseline file containing the verified public API surface (1449 lines) |
| PipelineFactory.cs | Updated to use JsonSerializer.Serialize instead of SimpleJson |
| IntrospectionEndpointHandler.cs | Updated to use JsonSerializer.Serialize instead of SimpleJson |
| SimpleJson.cs | Removed entire custom JSON library implementation |
| AssemblyInfo.cs | Added console capture configuration for tests |
| *.csproj | Added PublicApiGenerator and Verify.XunitV3 package references |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2194102 to
4542983
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
introspection/test/AspNetCore.Authentication.OAuth2Introspection.Tests/PublicApiVerification.cs
Outdated
Show resolved
Hide resolved
4542983 to
f136dd2
Compare
f136dd2 to
b646f31
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.