Skip to content
This repository was archived by the owner on Mar 3, 2022. It is now read-only.

Conversation

@emz00
Copy link

@emz00 emz00 commented Aug 30, 2019

@daun
Copy link

daun commented Nov 28, 2019

This would also help with patching the library. I currently have to maintain a patch that uses a different base64 algorithm and it's quite messy patching a minified JS file. This pull request would allow me to patch the un-minified source file.

@badrange
Copy link

I noticed that oidc-client.min.js was the largest package in our create-react-app build (258 kb) so I tried out this patch hoping that webpack would be able to remove some unused code.

Project still works!

And the package size stays the same, with jsrsasign.js showing up as the biggest file inside oidc-client with 129kb. I guess that might be because this library includes a minified version of it or something.

Would be great to get this PR merged! Then we might continue by changing how jsrasign is used in this project with the ultimate goal of having a smaller build for all the users of this library.

@brockallen brockallen added this to the 1.11.0 milestone Jul 21, 2020
@brockallen
Copy link
Contributor

Need to do some more research/tests to ensure this is not a breaking change.

@brockallen brockallen modified the milestones: 1.11.0, 1.12.0 Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants