🔧 [ShareableCardContent] Fixed so that profile photos are always output at a fixed size, regardless of the device's resolution, portrait or landscape orientation.#893
Merged
takahirom merged 3 commits intoDroidKaigi:mainfrom Sep 1, 2024
Conversation
… regardless of the device's resolution.
Corvus400
commented
Aug 31, 2024
| Box( | ||
| contentAlignment = Alignment.Center, | ||
| modifier = modifier | ||
| .requiredSize( |
Contributor
Author
There was a problem hiding this comment.
- On small devices like the SmallPhone, the resolution will be smaller than the specified size, so even if you specify 1200, the width will be adjusted to 720.
- So, we use requiredSize to ignore the width of the device and force the width to be 1200.
|
Snapshot diff report
|
Corvus400
changed the title
Corvus400
commented
Aug 31, 2024
Comment on lines
+91
to
+92
| val widthPx = 1200 | ||
| val heightPx = 630 |
Corvus400
commented
Aug 31, 2024
Comment on lines
+93
to
+94
| val cardWidthPx = 300 | ||
| val cardHeightPx = 380 |
Corvus400
changed the title
Corvus400
commented
Aug 31, 2024
Comment on lines
+95
to
+98
| val offsetXBackPx = 148f | ||
| val offsetYBackPx = 76f | ||
| val offsetXFrontPx = -136f | ||
| val offsetYFrontPx = -61f |
Contributor
Author
There was a problem hiding this comment.
There was a slight discrepancy between the figures, so I adjusted the values.
The result of the superimposition is as follows.
Now it is almost impossible to notice the discrepancy with the naked eye.
| OGP | Overlay | Exported image |
|---|---|---|
 |
 |
 |
Corvus400
changed the title
takahirom
added
the
awesome
takahirom
approved these changes
Sep 1, 2024
Member
takahirom
left a comment
takahirom
left a comment
There was a problem hiding this comment.
Looks great! Thank you for your detailed pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)