Skip to content

Use UI state in profile edit screen #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Masaki-U wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Use UI state in profile edit screen #508

Masaki-U wants to merge 10 commits into from

Conversation

@Masaki-U
Copy link

@Masaki-U Masaki-U commented Aug 16, 2024 •
edited
Loading

Issue

Overview (Required)

  • Create a data class to effectively diff compare stored image data.
  • Use Presenter data and events in profile editing screen.
  • Fix typo warning.
  • Encapsulate edit screen validation logic in UiState class.

@takahirom
Copy link
Member

takahirom commented Aug 16, 2024

Thank you for your pull request. Could you please resolve the conflict?

@Masaki-U
Copy link
Author

Masaki-U commented Aug 16, 2024

@takahirom
OK, resolve the conflict & refactoring complete!

@github-actions
Copy link

github-actions bot commented Aug 16, 2024

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 16, 2024 03:18 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 16, 2024 03:38 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 16, 2024 03:44 Inactive
@DroidKaigi DroidKaigi deleted a comment from github-actions bot Aug 16, 2024
@takahirom
Copy link
Member

takahirom commented Aug 16, 2024

I apologize. I created a similar issue, and there are conflicts in this PR. I believe we can still use your code, such as ImageData. Could you please resolve the conflict?

charles-b-stb
charles-b-stb reviewed Sep 5, 2024
View reviewed changes
...lecard/src/commonMain/kotlin/io/github/droidkaigi/confsched/profilecard/ProfileCardScreen.kt
""
}

val occupationError @Composable get() = if (occupation.isEmpty()) {
Copy link
Contributor

@charles-b-stb charles-b-stb Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same basic code format is repeated here three times... it might be worth to make a generic version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charles-b-stb charles-b-stb charles-b-stb left review comments

Assignees

No one assigned

Labels

Waiting for response or commit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use presenter in EditScreen in ProfileCard

3 participants

@Masaki-U @takahirom @charles-b-stb