You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
This component is similar to issue #228. However, this feature requires the use of TopAppBar, while issue #288 requires LargeTopAppBar, making it difficult to use a common component for both. Therefore, I implemented it separately and submitted a PR.
Thank you for your contribution. The animation is awesome. However, our designer prefers the #292 animation. Could you use AnimatedLargeTopAppBar instead? #292 (comment)
Thank you for your contribution. The animation is awesome. However, our designer prefers the #292 animation. Could you use AnimatedLargeTopAppBar instead? #292 (comment)
Sure! However, #292 uses a LargeTopAppBar with an icon at the top, while #293 uses a TopAppBar without an icon. If we use the AnimatedLargeTopAppBar as is, it will include a back icon at the top. Even if we set the icon to be optional and hide it, there will still be unnecessary padding.
So, instead of using AnimatedLargeTopAppBar, I used a custom component that I created and added the same fade-in and fade-out animations as in #292. What do you think about this approach? @takahirom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
AnimatedTextTopAppBarand applyabout featureLinks
Movie (Optional)
before.mp4
new_animation.mp4