[iOS] fix ios unintended timetable switching when favoriting a session

[gokuma]

Issue

• close When we favorite sessions on day 13 in the iOS app, the session list resets to day 12. #1033

Overview (Required)

The instability of the internalDay value is the cause of the issue, and the reason is likely because a new request is being made before the asynchronous stream of streamTimetable() inside the for loop has completed. As a result, the same streamTimetable result is processed multiple times, potentially overwriting the expected value of internalDay.

• added cancellation handling for each request, ensuring that a new request is not executed until the previous one has completed.

The issue may have been improved with #1036, but it still seems to occur, especially when adding/removing favorites quickly.

Links

• [iOS] fix ios timetable list/grid always reset on any action #1036

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before	After

Movie (Optional)

Before	After
before.mp4	after.mp4

[ry-itto]

Good catch! Thanks!

[gokuma]

CI is failing in a place that is not related to the fix.

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

same error:
#1028 (comment)