Skip to content

#104 Fixed navigationbar on detail screen. #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valjapan wants to merge 15 commits into
base: master
Choose a base branch
from
+11 −0
Open

#104 Fixed navigationbar on detail screen. #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
40d6b9e
#104 Issue resolved
valjapan Jan 20, 2020
f23c164
fix comment
valjapan Jan 22, 2020
110986b
check
valjapan Jan 22, 2020
178d3e9
fix conflict
valjapan Jan 22, 2020
10e117d
Merge pull request #1 from yukiyuki961/fix_issue_104_hardly_see_the_n…
valjapan Jan 22, 2020
f1f1dc6
fix can not see status bar
valjapan Jan 22, 2020
81e00ec
Avoid build version warning
valjapan Jan 22, 2020
12fbbdd
Merge pull request #2 from yukiyuki961/fix_issue_104_hardly_see_the_n…
valjapan Jan 22, 2020
a0b8c15
conflict resolbe
valjapan Jan 25, 2020
84baae1
fix conflict
valjapan Jan 29, 2020
f1f67c6
Merge remote-tracking branch 'upstream/master'
valjapan Feb 11, 2020
82d4cf5
fix issue and fix conflict
valjapan Feb 11, 2020
8d4cb72
Merge branch 'master' of github.com:DroidKaigi/conference-app-2020
valjapan Feb 11, 2020
56e4623
fix conflict
valjapan Feb 11, 2020
a08be2a
Merge pull request #3 from yukiyuki961/fix_issue_104_hardly_see_the_n…
valjapan Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...onfsched2020/ui/widget/SystemUiManager.kt → ...onfsched2020/ui/widget/SystemUiManager.kt
View file
Open in desktop
File renamed without changes.
11 changes: 11 additions & 0 deletions ...sion/src/main/java/io/github/droidkaigi/confsched2020/session/ui/SessionDetailFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import androidx.core.view.doOnNextLayout
import androidx.fragment.app.Fragment
import androidx.lifecycle.LifecycleOwner
import androidx.lifecycle.LiveData
import androidx.lifecycle.distinctUntilChanged
import androidx.lifecycle.observe
import androidx.navigation.NavOptions
import androidx.navigation.fragment.findNavController
Expand Down Expand Up @@ -44,6 +45,7 @@ import io.github.droidkaigi.confsched2020.session.ui.widget.SessionDetailItemDec
import io.github.droidkaigi.confsched2020.system.ui.viewmodel.SystemViewModel
import io.github.droidkaigi.confsched2020.ui.animation.MEDIUM_EXPAND_DURATION
import io.github.droidkaigi.confsched2020.ui.transition.fadeThrough
import io.github.droidkaigi.confsched2020.ui.widget.SystemUiManager
import javax.inject.Inject
import javax.inject.Provider

Expand Down Expand Up @@ -83,11 +85,20 @@ class SessionDetailFragment : Fragment(R.layout.fragment_session_detail), Inject
@Inject
lateinit var sessionDetailMaterialItemFactory: SessionDetailMaterialItem.Factory

private val navigationBarColors: SystemUiManager by lazy {
SystemUiManager(context!!)
}

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
sharedElementEnterTransition = fadeThrough().apply {
duration = MEDIUM_EXPAND_DURATION
}

navigationBarColors.systemUiVisibility.distinctUntilChanged().observe(this) {
activity?.window?.decorView?.systemUiVisibility =
Copy link
Copy Markdown
Member

@takahirom takahirom Jan 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
We are using SystemUiManager class. can you check it? 🙏

Copy link
Copy Markdown
Member Author

@valjapan valjapan Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takahirom
sorry. I was busy working and couldn't help.
Unfortunately I couldn't call SystemUiManager.
Could you give me any advice?

Copy link
Copy Markdown
Member

@takahirom takahirom Feb 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course!
How about moving SystemUiManager to corecomponet?

Copy link
Copy Markdown
Member Author

@valjapan valjapan Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takahirom
This is solved using SystemUiManager! Thank you for the advice!
commit a08be2a

View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR or View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR
Copy link
Copy Markdown
Collaborator

@jmatsu-bot jmatsu-bot Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Field requires API level 23 (current min is 21): android.view.View#SYSTEM_UI_FLAG_LIGHT_STATUS_BAR

Copy link
Copy Markdown
Collaborator

@jmatsu-bot jmatsu-bot Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Field requires API level 26 (current min is 21): android.view.View#SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR

}
}

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
Expand Down