fix(html-serializer): Remove support for single tilde syntax for strike-through text #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke-through text BREAKING CHANGE: Removed support for the single tilde syntax (e.g., `~text~`) for strike-through formatting. Please update your content to use the double tilde syntax (e.g., `~~text~~`) instead.
rfgamaral
added
the
👀 Show PR
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
doistbot
added a commit
that referenced
this pull request
Mar 17, 2025
## [8.0.0](v7.0.8...v8.0.0) (2025-03-17) ### ⚠ BREAKING CHANGES * **html-serializer:** Removed support for the single tilde syntax (e.g., `~text~`) for strike-through formatting. Please update your content to use the double tilde syntax (e.g., `~~text~~`) instead. ### Bug Fixes * **html-serializer:** Remove support for single tilde syntax for strike-through text ([#1055](#1055)) ([95c7231](95c7231))
Member
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What the title says 👆
The goal is to make sure that the Markdown syntax used by Typist matches the most commonly accepted syntax for strike-through text, given the lack of a proper CommonMark standard. This decision also matches GitHub Flavored Markdown syntax, which is widely accepted.
PR Checklist
Test plan
Rich-text → Defaultstory~strike~into thecontentcontrol~strike~appears in the editor as-is (not strike-through)