feat: [BREAKING] enforce max-params ESLint rule with limit of 3 #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add max-params ESLint rule set to error with 3 parameter limit
- Disable rule for test files to allow flexibility in test setup
- Refactor getAuthorizationUrl() to use options object instead of 4 separate parameters
- Add ESLint exception for TodoistRequestError constructor
BREAKING CHANGE: getAuthorizationUrl() now accepts an options object instead of individual parameters.
Before: getAuthorizationUrl(clientId, permissions, state, baseUrl)
After: getAuthorizationUrl({ clientId, permissions, state, baseUrl })
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
- Update test.each calls to use options object instead of individual parameters - Update error test case to use new function signature - All tests now passing with new API 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
max-paramsESLint rule with 3-parameter limit and error severitygetAuthorizationUrl()to use options object pattern for cleaner APIBreaking Change
The
getAuthorizationUrl()function now accepts an options object instead of individual parameters:Before:
After:
Test plan
🤖 Generated with Claude Code