Skip to content

Added deleteUserComment and getUserComments#220

Merged
DoctorMcKay merged 6 commits intoDoctorMcKay:masterfrom
Revadike:feature/profile-comments
Jul 22, 2021
Merged

Added deleteUserComment and getUserComments#220
DoctorMcKay merged 6 commits intoDoctorMcKay:masterfrom
Revadike:feature/profile-comments

Conversation

@Revadike
Copy link
Contributor

@Revadike Revadike commented Apr 4, 2019

Resolves #219 and resolves #208

The callback of postUserComment now returns the commentID as second parameter.
The function deleteUserComment takes userID, commentID and a callback as parameters respectively.
The function getUserComments takes userID, options and a callback as parameters respectively, where options is an object with start, count, etc.

@Revadike Revadike changed the title Updated postUserComment and added deleteUserComment Added deleteUserComment and getUserComments Apr 4, 2019
@Revadike
Copy link
Contributor Author

@DoctorMcKay what's holding you back from merging any of these open PR's?

@ghost
Copy link

ghost commented May 4, 2021

@DoctorMcKay I am currently needing this PR for a little project of mine, and I would really appreciate it if you could review it and hopefully merge it into the repo, as well as some of the other pr's in here. TYSM!

Co-authored-by: Mr-VIT <[email protected]>
@ghost

This comment has been minimized.

@Revadike
Copy link
Contributor Author

@Revadike Asking because I'm a total noob. How can I pull the comments from some person's profile? Also, I'm the guy that made the comment asking DoctorMcKay to please review it and merge it hehe

Why are you asking when the answer is already there? Just check the code and I explained it in the OP.

@ghost
Copy link

ghost commented May 19, 2021

@Revadike Asking because I'm a total noob. How can I pull the comments from some person's profile? Also, I'm the guy that made the comment asking DoctorMcKay to please review it and merge it hehe

Why are you asking when the answer is already there? Just check the code and I explained it in the OP.

And that's what happens when I don't read. I have no excuses, totally my bad. Sorry

@eaaliprantis
Copy link

Any update?

@DoctorMcKay
Copy link
Owner

Apparently it's possible on GitHub to start a review without actually submitting the comment, which I was unaware of.

@Revadike Revadike requested a review from DoctorMcKay July 22, 2021 05:49
@DoctorMcKay DoctorMcKay merged commit dfad525 into DoctorMcKay:master Jul 22, 2021
@Revadike Revadike deleted the feature/profile-comments branch July 22, 2021 06:51
@ghost
Copy link

ghost commented Jul 24, 2021

POG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add removeUserComment(id, callback) Add getProfileComments(steamid, start, count, callback)

4 participants