Improve performance of RFECV visualizer#1048
Open
bbengfort wants to merge 2 commits into
Open
Conversation
|
Hi, is there are working solution for #1047, that accelerates the RFECV to reach similar performance to the Sklearn implementation? |
This was referenced Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1047 which reported that yellowbrick's internal implementation of RFECV is much slower than scikit-learn's. This PR introduces a new implementation of
RFECVthat is closer to the latest version ofsklearn.RFECV.I have made the following changes:
_RFECVthat subclasses the sklearn implementation and adds our required functionalitySample Code and Plot
If you are adding or modifying a visualizer, PLEASE include a sample plot here along with the code you used to generate it.
TODOs and questions
Still to do:
Questions for the @DistrictDataLabs/team-oz-maintainers:
@lwgray @rebeccabilbro and @jc639 -- it would be great if we could work on this together
CHECKLIST
pytest?make html?