Skip to content

Fix: Intermittent IllegalStateException#180

Merged
Dimezis merged 1 commit into
Dimezis:masterfrom
tttcowan:fix_rendereffect_view_parent_view
Jun 14, 2022
Merged

Fix: Intermittent IllegalStateException#180
Dimezis merged 1 commit into
Dimezis:masterfrom
tttcowan:fix_rendereffect_view_parent_view

Conversation

@tttcowan

@tttcowan tttcowan commented Jun 1, 2022

Copy link
Copy Markdown

Guard against IllegalStateException caused by adding backgroundView to blurView when it already has a parent. This seems to be an intermittent problem I picked up from Crashlytics.

@tttcowan tttcowan changed the title Fix : Intermittent IllegalStateException Fix: Intermittent IllegalStateException Jun 1, 2022
@tttcowan

tttcowan commented Jun 1, 2022

Copy link
Copy Markdown
Author

image

@Dimezis

Dimezis commented Jun 1, 2022

Copy link
Copy Markdown
Owner

Thanks, I'll release it when I'm back from holidays

Dimezis added a commit that referenced this pull request Jun 14, 2022
…ffectBlur is used.

This should significantly improve the performance.
Now always downscaling the RenderNode in RenderEffectBlur by 2x.
RenderEffectBlur is completely rewritten and no longer accepts RenderEffectPrecision.
RenderEffectPrecision is removed.
Fix a crash in RenderEffectBlur - #180
@Dimezis Dimezis merged commit 9d7a593 into Dimezis:master Jun 14, 2022
@Dimezis

Dimezis commented Jun 14, 2022

Copy link
Copy Markdown
Owner

I released 2.0.1, but after some consideration, I'd advise to not use RenderEffectBlur at the moment.
It causes a constant BlurView redrawing which adds a big overhead.
I'll keep investigating how to improve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants