Using after:deploy:deploy hook instead of after:aws:deploy:finalize:cleanup #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pi-gateway-caching into bug/use-deploy-hook # Conflicts: # src/stageCache.js
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API Gateway caching plugin to use the new hook ('after:deploy:deploy') and removes redundant safeguard comments from the stage cache update logic.
- Changed hook from 'after:aws:deploy:finalize:cleanup' to 'after:deploy:deploy' in the API Gateway caching plugin.
- Removed redundant safeguard comments in the stage cache update function.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/stageCache.js | Removed redundant safeguard comments in the update loop logic. |
| src/apiGatewayCachingPlugin.js | Updated the deploy hook to the new 'after:deploy:deploy' hook as per current deployment workflow changes. |
Files not reviewed (1)
- package.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.