Skip to content

Conversation

@josh-feather
Copy link
Contributor

@josh-feather josh-feather commented May 8, 2024

Changes made in the 1.10.3 release made cache-key parameters required by default, changing the behaviour from 1.10.2 and introducing a breaking change.

This PR addresses the last comment by @DianaIonita in #134 suggesting we go back to making cache-key parameters optional by default, whilst still being able to make them required via events.http.request.parameters:

Hi everyone,

This is my suggestion:

set the default of not required on cache key parameters
if anyone wants to require cache key parametres, they can do it via the already existing serverless framework config (events.http.request.parameters)
This way, we avoid the confusion of having two config options that do the same thing. It also doesn't need the developer to remember any special behaviours of this caching plugin.

Fixes #133

@josh-feather josh-feather changed the title Change default value of Method RequestParameters from true to false #133 Change default value of Method RequestParameters from true to false May 8, 2024
@DianaIonita
Copy link
Owner

Much appreciated @josh-feather!

@DianaIonita DianaIonita merged commit eb1fac2 into DianaIonita:develop May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cacheKeyParameters are always required as of 1.10.3

2 participants