This repository was archived by the owner on Sep 9, 2024. It is now read-only.
JENKINS-68249 - change from png to svg #346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanuelflp
changed the title
craigwebb-xft
approved these changes
Jan 24, 2023
m-hruby
approved these changes
Apr 12, 2023
RHeynsZa
approved these changes
May 29, 2023
|
Anyone to approve and merge this? |
hellemansjelle
suggested changes
Sep 21, 2023
| html.push(' <a id="startpipeline-' + c +'" class="task-icon-link" href="#" onclick="triggerBuild(\'' + component.firstJobUrl + '\', \'' + data.name + '\')">'); | ||
| } | ||
| html.push('<img class="icon-clock icon-md" title="Build now" src="' + resURL + '/images/24x24/clock.png">'); | ||
| html.push('<img class="icon-clock icon-md" title="Build now" src="' + resURL + '/images/24x24/clock.svg">'); |
There was a problem hiding this comment.
I think this should be '/images/svgs/clock.svg'
|
The same issue his being fixed here: #347 just fyi, we are also affected by this, and we would appreciate if this fix lands in the next plugin version if possible :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Jenkins move to use SVG as default in your internal images, this PR adjusts to use it. See Here
Resolves this Issue