Catch residuals from OrdinaryDiffEq internals#2587
Draft
SouthEndMusic wants to merge 1 commit intomainfrom
Draft
Catch residuals from OrdinaryDiffEq internals#2587SouthEndMusic wants to merge 1 commit intomainfrom
SouthEndMusic wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
I realize now that this can probably be simplified, because now we compute averages both in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also https://github.com/Deltares/Ribasim/pull/2448/files.
The benefit here is that we catch each computation of the residuals, and do not depend on reaching into an internal cache which might break at some point.