Conversation
Fixes #2072. It was possible to let one FlowBoundary flow into multiple Basins. This is no longer allowed, so this is a breaking change. As far as I know it wasn't used though. It is quite confusing to have multiple outflow neighbours, because a Q at the FlowBoundary that goes to n Basins then becomes a nQ total inflow. And usually a FlowBoundary represents a single physical inflow point, that should always go to one point only. The LevelBoundary can still be connected via resistance nodes to multiple Basins, but this makes sense when representing e.g. the sea.
visr
commented
Mar 31, 2025
| model.basin[1], | ||
| name="duplicate", | ||
| name="multiple-outflows", | ||
| ) |
Member
Author
There was a problem hiding this comment.
I tried to come up with a link.add that triggers the unique edges validation first, but I don't think we can trigger it anymore because we'd need a from_node that supports multiple outputs and to_node that supports multiple inputs, that are allowed to be connected. I don't think that exists anymore.
visr
added a commit
that referenced
this pull request
Apr 15, 2025
## [v2025.3.0] - 2025-04-14 The only breaking change in this release is to disallow connecting a single FlowBoundary to multiple Basins. There are large improvements in the ability to visualize results on the map in QGIS. We also welcome the Junction node to the family, which will help laying out networks in a recognizable manner. ### Added - Add spatio-temporal results layers to QGIS. [#2208](#2208) - Add topological (straight line) link view toggle to QGIS. [#2208](#2208) - Added [Junction](https://ribasim.org/reference/node/junction.html) node type. [#2175](#2175) - Write results and log bottlenecks also on an interrupt or crash. [#2191](#2191) [#2200](#2200) - Log computation time and save it to `solver_stats.arrow`. [#2209](https://github.com/Deltares/Ribasim/pull/) - Experimental support for writing the model network and results into files used by Delft-FEWS, [`model.to_fews`](`https://ribasim.org/reference/python/Model.html#ribasim.Model.to_fews`). [#2161](#2161) - Document [`results/concentration.arrow`](https://ribasim.org/reference/usage.html#concentration---concentration.arrow). [#2165](#2165) ### Changed - Allow max 1 outflow neighbour for FlowBoundary. [#2192](#2192) - Automatic differentiation is enabled by default again, `autodiff = true`, leading to better performance. [#2137](#2137) [#2183](#2183)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2072. It was possible to let one FlowBoundary flow into multiple Basins. This is no longer allowed, so this is a breaking change. As far as I know it wasn't used though. It is quite confusing to have multiple outflow neighbours, because a Q at the FlowBoundary that goes to n Basins then becomes a nQ total inflow. And usually a FlowBoundary represents a single physical inflow point, that should always go to one point only.
The LevelBoundary can still be connected via resistance nodes to multiple Basins, but this makes sense when representing e.g. the sea.