Fix error when no approvers are specified#8
Merged
philn-delphia merged 1 commit intov2from Mar 3, 2026
Merged
Conversation
When both approvers and minimumApprovals are unset (the "anyone can approve" case), default minimumApprovals to 1 instead of returning an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approversis empty andminimumApprovalsis 0 (the "anyone can approve" case),approvalFromCommentswas returningerror: no required approvers or minimum approvals setinstead of allowing any commenter to approve.minimumApprovalsto 1 when both are unset.