Repository navigation
Bump go.opentelemetry.io/otel/sdk from 1.36.0 to 1.43.0 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/golang-migrate/migrate/v4 | ||
|
|
||
| go 1.24.0 | ||
| go 1.25.0 | ||
|
|
||
| require ( | ||
| cloud.google.com/go/spanner v1.85.0 | ||
|
|
@@ -30,7 +30,7 @@ require ( | |
| github.com/nakagami/firebirdsql v0.0.0-20190310045651-3c02a58cfed8 | ||
| github.com/neo4j/neo4j-go-driver v1.8.1-0.20200803113522-b626aa943eba | ||
| github.com/snowflakedb/gosnowflake v1.6.19 | ||
| github.com/stretchr/testify v1.10.0 | ||
| github.com/stretchr/testify v1.11.1 | ||
| github.com/xanzy/go-gitlab v0.15.0 | ||
| go.mongodb.org/mongo-driver v1.7.5 | ||
| golang.org/x/oauth2 v0.30.0 | ||
|
|
@@ -64,16 +64,16 @@ require ( | |
| github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect | ||
| github.com/spiffe/go-spiffe/v2 v2.5.0 // indirect | ||
| github.com/zeebo/errs v1.4.0 // indirect | ||
| go.opentelemetry.io/auto/sdk v1.1.0 // indirect | ||
| go.opentelemetry.io/auto/sdk v1.2.1 // indirect | ||
| go.opentelemetry.io/contrib/detectors/gcp v1.36.0 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.61.0 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.61.0 // indirect | ||
| go.opentelemetry.io/otel v1.37.0 // indirect | ||
| go.opentelemetry.io/otel v1.43.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.29.0 // indirect | ||
| go.opentelemetry.io/otel/metric v1.37.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.36.0 // indirect | ||
| go.opentelemetry.io/otel/sdk/metric v1.36.0 // indirect | ||
| go.opentelemetry.io/otel/trace v1.37.0 // indirect | ||
| go.opentelemetry.io/otel/metric v1.43.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.43.0 // indirect | ||
| go.opentelemetry.io/otel/sdk/metric v1.43.0 // indirect | ||
|
Comment on lines
66
to
+75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The core otel packages jump to v1.43.0, but several exporter/contrib packages remain behind:
Within otel's v1.x line the API is backward compatible, so this should compile. However, keeping the exporters 7–16 minor versions behind the SDK means you miss bug fixes (including the 4 MiB HTTP response body limit from #8108 in Prompt To Fix With AIThis is a comment left during a code review.
Path: go.mod
Line: 66-75
Comment:
**Partial otel exporter upgrade**
The core otel packages jump to v1.43.0, but several exporter/contrib packages remain behind:
- `go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.29.0`
- `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.27.0`
- `go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.36.0`
Within otel's v1.x line the API is backward compatible, so this should compile. However, keeping the exporters 7–16 minor versions behind the SDK means you miss bug fixes (including the 4 MiB HTTP response body limit from #8108 in `otlptracehttp`) that were landed in the exporter packages alongside the SDK. Consider bumping these to v1.43.0 as well.
How can I resolve this? If you propose a fix, please make it concise. |
||
| go.opentelemetry.io/otel/trace v1.43.0 // indirect | ||
| go.opentelemetry.io/proto/otlp v1.3.1 // indirect | ||
| golang.org/x/telemetry v0.0.0-20251008203120-078029d740a8 // indirect | ||
| golang.org/x/tools v0.38.0 // indirect | ||
|
|
@@ -187,7 +187,7 @@ require ( | |
| golang.org/x/mod v0.29.0 // indirect | ||
| golang.org/x/net v0.47.0 // indirect | ||
| golang.org/x/sync v0.18.0 // indirect | ||
| golang.org/x/sys v0.38.0 // indirect | ||
| golang.org/x/sys v0.42.0 // indirect | ||
| golang.org/x/term v0.37.0 // indirect | ||
| golang.org/x/text v0.31.0 // indirect | ||
| golang.org/x/time v0.12.0 // indirect | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
godirective was raised from1.24.0to1.25.0. Since Go 1.21, this directive acts as a minimum toolchain requirement — any consumer of this library will need Go 1.25+ to build it. This is a breaking change for users on older toolchains and is unrelated to the otel/sdk version bump described in the PR title. Was this intentional?Prompt To Fix With AI