Fix incorrect (inflated) numbers in top 10 metrics #13453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Maffooch
approved these changes
Oct 17, 2025
blakeaowens
approved these changes
Oct 18, 2025
rossops
approved these changes
Oct 20, 2025
rossops
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12248
The top_ten queries where counting findings from a query that was based on the product table. This led to multiple joins with other tables which led to 1 finding being included multiple times in the counts. The PR changes the queryset to start at the Finding model as that is what we want to count. Some mapping was needed to avoid having to change the metrics templates.
Incorrect from current demo instance:
Correct from local instance with fixes:
It does mean 1 extra query, but the first/existing query has become much simpler since the amount of joins has been reduced.