Skip to content

Fix DojoGroupSerializer to handle empty permissions list #13447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

Fix DojoGroupSerializer to handle empty permissions list #13447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1afc1d4
fix(serializers): Update DojoGroupSerializer to handle empty permissi…
Maffooch Oct 17, 2025
29a44ab
Accommodate the UserSerializer as well
Maffooch Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions dojo/api_v2/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,13 +536,13 @@ def to_representation(self, instance):
return ret

def update(self, instance, validated_data):
permissions_in_payload = None
new_configuration_permissions = None
if (
"user_permissions" in validated_data
): # This field was renamed from "configuration_permissions" in the meantime
new_configuration_permissions = set(
validated_data.pop("user_permissions"),
)
permissions_in_payload = validated_data.pop("user_permissions")
new_configuration_permissions = set(permissions_in_payload)

instance = super().update(instance, validated_data)

Expand All @@ -563,6 +563,10 @@ def update(self, instance, validated_data):
)
instance.user_permissions.set(new_permissions)

# Clear all configuration permissions if an empty list is provided
if isinstance(permissions_in_payload, list) and len(permissions_in_payload) == 0:
instance.user_permissions.clear()

return instance

def create(self, validated_data):
Expand Down Expand Up @@ -695,14 +699,14 @@ def create(self, validated_data):
return instance

def update(self, instance, validated_data):
permissions_in_payload = None
new_configuration_permissions = None
if (
"auth_group" in validated_data
and "permissions" in validated_data["auth_group"]
): # This field was renamed from "configuration_permissions" in the meantime
new_configuration_permissions = set(
validated_data.pop("auth_group")["permissions"],
)
permissions_in_payload = validated_data.pop("auth_group")["permissions"]
new_configuration_permissions = set(permissions_in_payload)

instance = super().update(instance, validated_data)

Expand All @@ -723,6 +727,10 @@ def update(self, instance, validated_data):
)
instance.auth_group.permissions.set(new_permissions)

# Clear all configuration permissions if an empty list is provided
if isinstance(permissions_in_payload, list) and len(permissions_in_payload) == 0:
instance.auth_group.permissions.clear()

return instance


Expand Down