feat(helm): DRY cloudsql-proxy #13369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@fernandezcuesta, could you please check it? |
kiblik
force-pushed
the
helm_dry_cloudsqlProxy
branch
from
075a61b to
d73a51b
Compare
valentijnscholten
approved these changes
Oct 8, 2025
rossops
approved these changes
Oct 9, 2025
Maffooch
approved these changes
Oct 10, 2025
Contributor
|
@kiblik I will leave to you to merge in case you would want @fernandezcuesta to look closer before it goes in |
fernandezcuesta
approved these changes
Oct 10, 2025
Contributor
There was a problem hiding this comment.
LGTM
Little bit weird that the function returns a list rather than a map, something like:
- {{- include "foo" . | nindent 6 }}Where you can visually see it's a single container.
But I feel it's just my own personal bias. Other than that it does its job!
Contributor
|
Based on the feedback above ☝️ I'm going to go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudsql-proxyis always the same. Let's DRY (Don't repeat yourself) it.