`DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL` matches unique ids from different parsers

[valentijnscholten]

In certain scenario's the DEDUPE_ALGO_UNIQUE_ID_FROM_TOOL algorithm can set a finding from scanner type A as duplicate of a finding from scanner type B. For this algorithm this is invalid as the unique_id_from_tool field is a parser specific value.

This only happens when deduplication_on_engagement==True. The product scope code branch already had the correct filter.

django-DefectDojo/dojo/utils.py

Lines 439 to 440 in 7c0d92a

	# the unique_id_from_tool is unique for a given tool: do not compare with other tools
	test__test_type=new_finding.test.test_type,

In practice I doubt many people will run into this small bug. It has been around for 5 years, so we would have noticed. So the real world impact of the bug is limited, but still I would like to get this corrected.